third_party/WebKit/Source/modules/webdatabase/ChangeVersionWrapper.cpp - Issue 2813433002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/webdatabase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webdatabase/ChangeVersionWrapper.cpp

Issue 2813433002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/webdatabase (Closed)

Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/webdatabase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/webdatabase/ChangeVersionWrapper.cpp

diff --git a/third_party/WebKit/Source/modules/webdatabase/ChangeVersionWrapper.cpp b/third_party/WebKit/Source/modules/webdatabase/ChangeVersionWrapper.cpp

index b37d4f7ac273c9dff7ac8d91c83c59cc20267d53..40e70af7c73b213472a21ff4f98732c25e7b334c 100644

--- a/third_party/WebKit/Source/modules/webdatabase/ChangeVersionWrapper.cpp

+++ b/third_party/WebKit/Source/modules/webdatabase/ChangeVersionWrapper.cpp

@@ -39,7 +39,8 @@ ChangeVersionWrapper::ChangeVersionWrapper(const String& old_version,

bool ChangeVersionWrapper::PerformPreflight(

SQLTransactionBackend* transaction) {

- ASSERT(transaction && transaction->GetDatabase());

+ DCHECK(transaction);

+ DCHECK(transaction->GetDatabase());

Database* database = transaction->GetDatabase();

@@ -66,7 +67,8 @@ bool ChangeVersionWrapper::PerformPreflight(

bool ChangeVersionWrapper::PerformPostflight(

SQLTransactionBackend* transaction) {

- ASSERT(transaction && transaction->GetDatabase());

+ DCHECK(transaction);

+ DCHECK(transaction->GetDatabase());

Database* database = transaction->GetDatabase();

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webdatabase/DOMWindowWebDatabase.cpp » ('j') | no next file with comments »