Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1305)

Issue 2813403002: Move LayouetSelection function definition from layout/LayoutView.cpp to editing/LayoutSelection.cpp (Closed)

Created:
3 years, 8 months ago by yoichio
Modified:
3 years, 8 months ago
Reviewers:
tkent, kojih, yosin_UTC9
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move LayouetSelection function definition from layout/LayoutView.cpp to editing/LayoutSelection.cpp This is just moving: https://codereview.chromium.org/2800813006/ TEST=No change in behavior. BUG=708453 Review-Url: https://codereview.chromium.org/2813403002 Cr-Commit-Position: refs/heads/master@{#464346} Committed: https://chromium.googlesource.com/chromium/src/+/0ce68a3d93044122537ef22d6490319bac338c88

Patch Set 1 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -291 lines) Patch
M third_party/WebKit/Source/core/editing/LayoutSelection.cpp View 3 chunks +286 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 3 chunks +0 lines, -291 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
yoichio
3 years, 8 months ago (2017-04-13 03:48:04 UTC) #6
yoichio
3 years, 8 months ago (2017-04-13 05:06:36 UTC) #10
yosin_UTC9
lgtm
3 years, 8 months ago (2017-04-13 05:46:46 UTC) #11
yoichio
Kent, could you take a look?
3 years, 8 months ago (2017-04-13 08:26:34 UTC) #13
tkent
lgtm
3 years, 8 months ago (2017-04-13 08:32:14 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813403002/20001
3 years, 8 months ago (2017-04-13 08:37:34 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 08:59:47 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0ce68a3d93044122537ef22d6490...

Powered by Google App Engine
This is Rietveld 408576698