Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2813393002: Add //net deps for remoting/host/setup stuff. (Closed)

Created:
3 years, 8 months ago by mattm
Modified:
3 years, 8 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, mac-reviews_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add //net deps for remoting/host/setup stuff. Example errors: In file included from ../../remoting/host/setup/start_host_main.cc:18: In file included from ../../net/url_request/url_fetcher.h:19: In file included from ../../net/url_request/url_request.h:26: In file included from ../../net/base/net_error_details.h:9: In file included from ../../net/http/http_response_info.h:14: In file included from ../../net/ssl/ssl_info.h:20: In file included from ../../net/ssl/ssl_config.h:12: In file included from ../../net/cert/x509_certificate.h:25: ../../third_party/boringssl/src/include/openssl/base.h:68:10: fatal error: 'openssl/opensslconf.h' file not found In file included from ../../remoting/host/setup/me2me_native_messaging_host_main.cc:22: In file included from ../../net/url_request/url_fetcher.h:19: In file included from ../../net/url_request/url_request.h:26: In file included from ../../net/base/net_error_details.h:9: In file included from ../../net/http/http_response_info.h:14: In file included from ../../net/ssl/ssl_info.h:20: In file included from ../../net/ssl/ssl_config.h:12: In file included from ../../net/cert/x509_certificate.h:25: ../../third_party/boringssl/src/include/openssl/base.h:68:10: fatal error: 'openssl/opensslconf.h' file not found BUG=none Review-Url: https://codereview.chromium.org/2813393002 Cr-Commit-Position: refs/heads/master@{#464301} Committed: https://chromium.googlesource.com/chromium/src/+/4cbdb69bfe995d705f6cee9122c43999f9fbbfa6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M remoting/host/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/linux/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/mac/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
mattm
3 years, 8 months ago (2017-04-13 01:19:33 UTC) #2
Sergey Ulanov
lgtm
3 years, 8 months ago (2017-04-13 02:20:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813393002/1
3 years, 8 months ago (2017-04-13 04:29:56 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 04:53:20 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4cbdb69bfe995d705f6cee9122c4...

Powered by Google App Engine
This is Rietveld 408576698