Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2813303004: DevTools: fix date with version, image for What's New (Closed)

Created:
3 years, 8 months ago by chenwilliam
Modified:
3 years, 8 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix date with version, image for What's New * Use a customizable header string * Make png smaller BUG=682879 Review-Url: https://codereview.chromium.org/2813303004 Cr-Commit-Position: refs/heads/master@{#464662} Committed: https://chromium.googlesource.com/chromium/src/+/629219eb67f0a5d7ce30f0729870b584d307c897

Patch Set 1 #

Patch Set 2 : use tinypng #

Total comments: 1

Patch Set 3 : use header string #

Messages

Total messages: 14 (8 generated)
chenwilliam
Please take a look - hopefully can land before branch point.
3 years, 8 months ago (2017-04-13 19:19:02 UTC) #2
pfeldman
Why jpeg?
3 years, 8 months ago (2017-04-13 20:45:06 UTC) #3
chenwilliam
The webp image wasn't being served properly in DevTools release mode - I'll investigate further. ...
3 years, 8 months ago (2017-04-13 22:26:52 UTC) #6
pfeldman
lgtm % nit. https://codereview.chromium.org/2813303004/diff/40001/third_party/WebKit/Source/devtools/front_end/help/ReleaseNoteText.js File third_party/WebKit/Source/devtools/front_end/help/ReleaseNoteText.js (right): https://codereview.chromium.org/2813303004/diff/40001/third_party/WebKit/Source/devtools/front_end/help/ReleaseNoteText.js#newcode15 third_party/WebKit/Source/devtools/front_end/help/ReleaseNoteText.js:15: chromeVersion: 59, Let's make it a ...
3 years, 8 months ago (2017-04-13 23:23:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813303004/60001
3 years, 8 months ago (2017-04-13 23:57:25 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 02:45:54 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/629219eb67f0a5d7ce30f0729870...

Powered by Google App Engine
This is Rietveld 408576698