Fix Mash Browser Test Startup Race

Fix Mash Browser Test Startup Race

MojoTestConnector initialized a BackgroundServiceManager at creation time. Later
on it initializes mojo.

Due to this, it was possible for BackgroundServiceManager to attempt to create
mojo pipes for its catalog, before mojo has been initialized. Crashing the test
suite.

This change updates MojoTestConnector to delay the creation of
BackgroundServiceManager until it has explicitly created the mojo pipe.

TEST=mash_browser_tests
BUG=678687
Review-Url: https://codereview.chromium.org/2813293003
Cr-Commit-Position: refs/heads/master@{#465217}
Committed: https://chromium.googlesource.com/chromium/src/+/4b7194fc64ee783975d60d364cb4b3cdeca58bd4

[jonross, 2017-04-13 20:46:30]

jonross@chromium.org changed reviewers:
+ sky@chromium.org

[jonross, 2017-04-13 20:46:31]

Hey sky@,

Could you take a look at this review? I ran into a new race in the
mash_browser_tests suite.

Thanks,
Jon

[sky, 2017-04-17 16:57:33]

LGTM

[jonross, 2017-04-18 13:18:50]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2017-04-18 13:19:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 13:48:03]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492521530930510, "parent_rev":
"186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9", "commit_rev":
"4b7194fc64ee783975d60d364cb4b3cdeca58bd4"}

[commit-bot: I haz the power, 2017-04-18 13:48:10]

Description was changed from

==========
Fix Mash Browser Test Startup Race

MojoTestConnector initialized a BackgroundServiceManager at creation time. Later
on it initializes mojo.

Due to this, it was possible for BackgroundServiceManager to attempt to create
mojo pipes for its catalog, before mojo has been initialized. Crashing the test
suite.

This change updates MojoTestConnector to delay the creation of
BackgroundServiceManager until it has explicitly created the mojo pipe.

TEST=mash_browser_tests
BUG=678687
==========

to

==========
Fix Mash Browser Test Startup Race

MojoTestConnector initialized a BackgroundServiceManager at creation time. Later
on it initializes mojo.

Due to this, it was possible for BackgroundServiceManager to attempt to create
mojo pipes for its catalog, before mojo has been initialized. Crashing the test
suite.

This change updates MojoTestConnector to delay the creation of
BackgroundServiceManager until it has explicitly created the mojo pipe.

TEST=mash_browser_tests
BUG=678687

Review-Url: https://codereview.chromium.org/2813293003
Cr-Commit-Position: refs/heads/master@{#465217}
Committed:
https://chromium.googlesource.com/chromium/src/+/4b7194fc64ee783975d60d364cb4...
==========

[commit-bot: I haz the power, 2017-04-18 13:48:11]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4b7194fc64ee783975d60d364cb4...