Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2813273003:
Update the binary integrity incident designated requirement. (Closed)
DescriptionUpdate the binary integrity incident designated requirement.
This updates the designated requirement used in Chrome's
binary integrity incident checks to be the same designated
requirement that Chrome is signed with. Specifically, it uses
the certificate hash instead of the team identifier.
BUG=703793
DONOTSUBMIT=true
Review-Url: https://codereview.chromium.org/2813273003
Cr-Commit-Position: refs/heads/master@{#472210}
Committed: https://chromium.googlesource.com/chromium/src/+/d0b1f6ba5be856aed34c174a5630b89665e76bf5
Patch Set 1 #Patch Set 2 : Update the binary integrity incident designated requirement. #
Messages
Total messages: 25 (18 generated)
The CQ bit was checked by kerrnel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by kerrnel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by kerrnel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
kerrnel@chromium.org changed reviewers: + mark@chromium.org
PTAL. Thanks, Greg
LGTM
kerrnel@chromium.org changed reviewers: + caitkp@chromium.org
caitkp@chromium.org: Please review changes. Thanks, Greg
Description was changed from ========== Update the binary integrity incident designated requirement. This updates the designated requirement used in Chrome's binary integrity incident checks to be the same designated requirement that Chrome is signed with. Specifically, it uses the certificate hash instead of the team identifier. BUG=703793 DONOTSUBMIT=true ========== to ========== Update the binary integrity incident designated requirement. This updates the designated requirement used in Chrome's binary integrity incident checks to be the same designated requirement that Chrome is signed with. Specifically, it uses the certificate hash instead of the team identifier. BUG=703793 DONOTSUBMIT=true ==========
kerrnel@chromium.org changed reviewers: - caitkp@chromium.org
kerrnel@chromium.org changed reviewers: + nparker@chromium.org
nparker@chromium.org: Please provide an OWNERS review. Thanks, Greg
LGTM
The CQ bit was checked by kerrnel@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494961665036330,
"parent_rev": "3c7cb2453c28f2561eef9a880a4eb6fc8dae54c5", "commit_rev":
"d0b1f6ba5be856aed34c174a5630b89665e76bf5"}
Message was sent while issue was closed.
Description was changed from ========== Update the binary integrity incident designated requirement. This updates the designated requirement used in Chrome's binary integrity incident checks to be the same designated requirement that Chrome is signed with. Specifically, it uses the certificate hash instead of the team identifier. BUG=703793 DONOTSUBMIT=true ========== to ========== Update the binary integrity incident designated requirement. This updates the designated requirement used in Chrome's binary integrity incident checks to be the same designated requirement that Chrome is signed with. Specifically, it uses the certificate hash instead of the team identifier. BUG=703793 DONOTSUBMIT=true Review-Url: https://codereview.chromium.org/2813273003 Cr-Commit-Position: refs/heads/master@{#472210} Committed: https://chromium.googlesource.com/chromium/src/+/d0b1f6ba5be856aed34c174a5630... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/d0b1f6ba5be856aed34c174a5630... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
