Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2813213003: Disable another test failing on Linux MSAN tests on chromium.memory (Closed)

Created:
3 years, 8 months ago by jdoerrie
Modified:
3 years, 8 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable another test failing on Linux MSAN tests on chromium.memory As a follow up to r464367 this conditionally disables GpuImageDecodeCacheTest.GetTaskForImageCanceledGetsNewTask TBR=thakis@chromium.org, danakj@chromium.org, fsamuel@chromium.org, dalecurtis@chromium.org BUG=697171, 709341 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2813213003 Cr-Commit-Position: refs/heads/master@{#464425} Committed: https://chromium.googlesource.com/chromium/src/+/995002514a6d75ab8065ff7e995ea9e9a1a93951

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update Bug Number #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M cc/tiles/gpu_image_decode_cache_unittest.cc View 1 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813213003/1
3 years, 8 months ago (2017-04-13 14:47:27 UTC) #3
Nico
lgtm, thanks, but: https://codereview.chromium.org/2813213003/diff/1/cc/tiles/gpu_image_decode_cache_unittest.cc File cc/tiles/gpu_image_decode_cache_unittest.cc (right): https://codereview.chromium.org/2813213003/diff/1/cc/tiles/gpu_image_decode_cache_unittest.cc#newcode514 cc/tiles/gpu_image_decode_cache_unittest.cc:514: // crbug.com/697171. can you make this ...
3 years, 8 months ago (2017-04-13 15:06:36 UTC) #5
jdoerrie
https://codereview.chromium.org/2813213003/diff/1/cc/tiles/gpu_image_decode_cache_unittest.cc File cc/tiles/gpu_image_decode_cache_unittest.cc (right): https://codereview.chromium.org/2813213003/diff/1/cc/tiles/gpu_image_decode_cache_unittest.cc#newcode514 cc/tiles/gpu_image_decode_cache_unittest.cc:514: // crbug.com/697171. On 2017/04/13 15:06:36, Nico wrote: > can ...
3 years, 8 months ago (2017-04-13 15:20:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813213003/20001
3 years, 8 months ago (2017-04-13 15:20:44 UTC) #10
danakj
-me +ericrk
3 years, 8 months ago (2017-04-13 15:26:36 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 16:05:09 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/995002514a6d75ab8065ff7e995e...

Powered by Google App Engine
This is Rietveld 408576698