Moved/renamed EscapeString from visual_studio_writer to XmlEscape in xml_element_writer.

Moved/renamed EscapeString from visual_studio_writer to XmlEscape in xml_element_writer.

Added XmlEscape unit test.

BUG=708705
Review-Url: https://codereview.chromium.org/2813213002
Cr-Commit-Position: refs/heads/master@{#464756}
Committed: https://chromium.googlesource.com/chromium/src/+/ac2df0acb000d21cd5493fdcc529212d1ba65198

[kylix_rd, 2017-04-12 16:27:58]

Description was changed from

==========
Moved/renamed EscapeString from visual_studio_writer to XmlEscape in
xml_element_writer.

Added XmlEscape unit test.

BUG=708705
==========

to

==========
Moved/renamed EscapeString from visual_studio_writer to XmlEscape in
xml_element_writer.

Added XmlEscape unit test.

BUG=708705
==========

[kylix_rd, 2017-04-12 16:27:58]

kylixrd@chromium.org changed reviewers:
+ brettw@chromium.org

[kylix_rd, 2017-04-12 16:31:21]

Before I roll a new GN, I wanted to get at least a little test coverage. I also
moved/renamed the function to xml_element_writer since it's more related to XML
writing in general. It is also more generally available for non-VS project XML
writing operations.

[kylix_rd, 2017-04-13 18:20:52]

Another gentle ping.

[brettw, 2017-04-14 18:09:05]

lgtm

[kylix_rd, 2017-04-14 18:10:32]

The CQ bit was checked by kylixrd@chromium.org

[commit-bot: I haz the power, 2017-04-14 18:10:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 18:23:44]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492193432528230, "parent_rev":
"d7205b398e80becc61caca85c372f7c751940d3b", "commit_rev":
"ac2df0acb000d21cd5493fdcc529212d1ba65198"}

[commit-bot: I haz the power, 2017-04-14 18:24:34]

Description was changed from

==========
Moved/renamed EscapeString from visual_studio_writer to XmlEscape in
xml_element_writer.

Added XmlEscape unit test.

BUG=708705
==========

to

==========
Moved/renamed EscapeString from visual_studio_writer to XmlEscape in
xml_element_writer.

Added XmlEscape unit test.

BUG=708705

Review-Url: https://codereview.chromium.org/2813213002
Cr-Commit-Position: refs/heads/master@{#464756}
Committed:
https://chromium.googlesource.com/chromium/src/+/ac2df0acb000d21cd5493fdcc529...
==========

[commit-bot: I haz the power, 2017-04-14 18:24:35]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ac2df0acb000d21cd5493fdcc529...