Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 2813193003: MD Settings: Internet: Fix secure icon and badge colors (Closed)

Created:
3 years, 8 months ago by stevenjb
Modified:
3 years, 8 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-elements_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Internet: Fix secure icon and badge colors BUG=704008 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2813193003 Cr-Commit-Position: refs/heads/master@{#464240} Committed: https://chromium.googlesource.com/chromium/src/+/a83687c6c41879be7fb501972457d55bfe1ee2af

Patch Set 1 #

Total comments: 2

Patch Set 2 : svgomg output #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M ui/webui/resources/cr_elements/network/cr_network_icon.html View 3 chunks +5 lines, -3 lines 0 comments Download
M ui/webui/resources/cr_elements/network/network_icons.html View 1 2 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
stevenjb
3 years, 8 months ago (2017-04-12 19:27:10 UTC) #3
michaelpg
lgtm but the converted numbers are wacky, we usually round those (see below) https://codereview.chromium.org/2813193003/diff/1/ui/webui/resources/cr_elements/network/network_icons.html File ...
3 years, 8 months ago (2017-04-12 23:57:30 UTC) #4
stevenjb
https://codereview.chromium.org/2813193003/diff/1/ui/webui/resources/cr_elements/network/network_icons.html File ui/webui/resources/cr_elements/network/network_icons.html (right): https://codereview.chromium.org/2813193003/diff/1/ui/webui/resources/cr_elements/network/network_icons.html#newcode28 ui/webui/resources/cr_elements/network/network_icons.html:28: <path d="M1,3.99980749 C1,3.44762906 1.45097518,3 1.99077797,3 L6.00922203,3 C6.55641359,3 7,3.44371665 7,3.99980749 ...
3 years, 8 months ago (2017-04-13 00:08:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813193003/20001
3 years, 8 months ago (2017-04-13 00:09:31 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 01:56:31 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a83687c6c41879be7fb501972457...

Powered by Google App Engine
This is Rietveld 408576698