Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2813183002: [turbofan] Do not eagerly kill elements for slow transitions in loop state. (Closed)

Created:
3 years, 8 months ago by Benedikt Meurer
Modified:
3 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Do not eagerly kill elements for slow transitions in loop state. R=jarin@chromium.org BUG=v8:5267 Review-Url: https://codereview.chromium.org/2813183002 Cr-Commit-Position: refs/heads/master@{#44612} Committed: https://chromium.googlesource.com/v8/v8/+/ca5f7f4d131c99d407c8fd7efadb98d2db030eea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M src/compiler/load-elimination.cc View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Benedikt Meurer
3 years, 8 months ago (2017-04-12 12:01:43 UTC) #1
Jarin
lgtm
3 years, 8 months ago (2017-04-12 12:14:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813183002/1
3 years, 8 months ago (2017-04-12 12:26:47 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 12:28:48 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/ca5f7f4d131c99d407c8fd7efadb98d2db0...

Powered by Google App Engine
This is Rietveld 408576698