Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2813103004: Do additional blit and Present on first draw to overlay. (Closed)

Created:
3 years, 8 months ago by jbauman
Modified:
3 years, 8 months ago
Reviewers:
sunnyps
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Do additional blit and Present on first draw to overlay. It's unclear why this is necessary, but it seems to fix Pixel_DirectComposition_Video_MP4. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2813103004 Cr-Commit-Position: refs/heads/master@{#464601} Committed: https://chromium.googlesource.com/chromium/src/+/7c2bb41a8275988ed20cbf8f5dbaba08a0f9f222

Patch Set 1 #

Patch Set 2 : fix test #

Total comments: 2

Patch Set 3 : improve #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M gpu/ipc/service/direct_composition_surface_win.cc View 1 2 1 chunk +22 lines, -1 line 0 comments Download
M gpu/ipc/service/direct_composition_surface_win_unittest.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (16 generated)
jbauman
3 years, 8 months ago (2017-04-13 20:55:32 UTC) #9
sunnyps
lgtm % nits https://codereview.chromium.org/2813103004/diff/20001/gpu/ipc/service/direct_composition_surface_win.cc File gpu/ipc/service/direct_composition_surface_win.cc (right): https://codereview.chromium.org/2813103004/diff/20001/gpu/ipc/service/direct_composition_surface_win.cc#newcode421 gpu/ipc/service/direct_composition_surface_win.cc:421: // lost somehow and it shows ...
3 years, 8 months ago (2017-04-13 21:03:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813103004/40001
3 years, 8 months ago (2017-04-13 22:09:53 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 23:19:49 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7c2bb41a8275988ed20cbf8f5dba...

Powered by Google App Engine
This is Rietveld 408576698