Make all ComplexFeatures of single feature to be SimpleFeature.

Make all ComplexFeatures with single feature to be SimpleFeature.

Change DCHECK in ComplexFeature to ensure it has > 1 features.

BUG=710718
Test=Compile & run chrome.

Review-Url: https://codereview.chromium.org/2813073003
Cr-Commit-Position: refs/heads/master@{#464051}
Committed: https://chromium.googlesource.com/chromium/src/+/3f03a9bc2664344b6ee326f7540db022bbb4952f

[lazyboy, 2017-04-12 01:10:10]

The CQ bit was checked by lazyboy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 01:10:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lazyboy, 2017-04-12 01:10:53]

Description was changed from

==========
Make all ComplexFeatures of single feature to be SimpleFeature.

Change DCHECK in ComplexFeature to ensure it has > 1 features.

BUG=None
Test=Compile & run chrome.
==========

to

==========
Make all ComplexFeatures with single feature to be SimpleFeature.

Change DCHECK in ComplexFeature to ensure it has > 1 features.

BUG=None
Test=Compile & run chrome.
==========

[lazyboy, 2017-04-12 01:11:14]

lazyboy@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[Devlin, 2017-04-12 01:22:17]

thanks!  LGTM

For bonus points, we can/should put a check in the feature compiler, so that
this is a compile-time warning (rather than just a runtime crash).  Doesn't
necessarily need to happen in this CL, though.

[lazyboy, 2017-04-12 01:44:43]

Description was changed from

==========
Make all ComplexFeatures with single feature to be SimpleFeature.

Change DCHECK in ComplexFeature to ensure it has > 1 features.

BUG=None
Test=Compile & run chrome.
==========

to

==========
Make all ComplexFeatures with single feature to be SimpleFeature.

Change DCHECK in ComplexFeature to ensure it has > 1 features.

BUG=710718
Test=Compile & run chrome.
==========

[lazyboy, 2017-04-12 01:44:52]

On 2017/04/12 01:22:17, Devlin wrote:
> thanks!  LGTM
> 
> For bonus points, we can/should put a check in the feature compiler, so that
> this is a compile-time warning (rather than just a runtime crash).  Doesn't
> necessarily need to happen in this CL, though.

Thanks, I've filed https://crbug.com/710718, and will use this CL for that bug
too.

[lazyboy, 2017-04-12 01:45:04]

The CQ bit was checked by lazyboy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 01:45:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 02:36:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 02:36:51]

Dry run: This issue passed the CQ dry run.

[lazyboy, 2017-04-12 16:17:34]

The CQ bit was checked by lazyboy@chromium.org

[commit-bot: I haz the power, 2017-04-12 16:18:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 16:25:48]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492013854986330,
"parent_rev": "7ed11ddd4311e1e7a4dcd7169d9e24be52c15ed4", "commit_rev":
"3f03a9bc2664344b6ee326f7540db022bbb4952f"}

[commit-bot: I haz the power, 2017-04-12 16:27:59]

Description was changed from

==========
Make all ComplexFeatures with single feature to be SimpleFeature.

Change DCHECK in ComplexFeature to ensure it has > 1 features.

BUG=710718
Test=Compile & run chrome.
==========

to

==========
Make all ComplexFeatures with single feature to be SimpleFeature.

Change DCHECK in ComplexFeature to ensure it has > 1 features.

BUG=710718
Test=Compile & run chrome.

Review-Url: https://codereview.chromium.org/2813073003
Cr-Commit-Position: refs/heads/master@{#464051}
Committed:
https://chromium.googlesource.com/chromium/src/+/3f03a9bc2664344b6ee326f7540d...
==========

[commit-bot: I haz the power, 2017-04-12 16:28:00]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3f03a9bc2664344b6ee326f7540d...