Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2813073002: [Merge M58] arc: Restore Chrome badging for apps that have peer in Android apps. (Closed)

Created:
3 years, 8 months ago by khmel
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Merge M58] arc: Restore Chrome badging for apps that have peer in Android apps. This fix issue when running app for such apps does not have Chrome badging. This CL does not apply AppWindow icon to shelf item if window does not override its default icon. AppWindow might have its own icon (sine M54), however if it is not set then app icon is used. From other side shelf launcher controller has extra logic by applying additional badging over the icon. TEST=Manually BUG=708830 BUG=b/35258599 TBR=msw@chromium.org,reillyg@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2804623004 Cr-Commit-Position: refs/heads/master@{#462661} (cherry picked from commit 3d8e30ac4d15e9f85e57423bc38eaafd762dd821) Review-Url: https://codereview.chromium.org/2813073002 Cr-Commit-Position: refs/branch-heads/3029@{#675} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/231c83116e0db5ae649af12080d7498ad207a06f

Patch Set 1 #

Patch Set 2 : fix merge conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -12 lines) Patch
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc View 1 1 chunk +20 lines, -7 lines 0 comments Download
M chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc View 2 chunks +9 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/app_icon/test.js View 1 chunk +10 lines, -1 line 0 comments Download
M extensions/browser/app_window/app_window.h View 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/browser/app_window/app_window.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 10 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813073002/20001
3 years, 8 months ago (2017-04-12 02:26:51 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 02:34:56 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/231c83116e0db5ae649af12080d7...

Powered by Google App Engine
This is Rietveld 408576698