Deprecate cache_expression_exact_match

Deprecate cache_expression_exact_match

Deprecate cache_expression_exact_match proto field in
LoginRepurationResponse, and remove its related matching
logic and tests.

After looking closer at the site_chunk rules, using a
simple boolean cache_expression_exact_match field is 
not enough for some corner cases. Therefore, we
proposed to make the backend compute the most
appropriate cache_expression for all the corner cases
(instead of handling complex logic in client.) 
go/cache_expression_matching

BUG=698899
Review-Url: https://codereview.chromium.org/2813063003
Cr-Commit-Position: refs/heads/master@{#464225}
Committed: https://chromium.googlesource.com/chromium/src/+/eb38d9eecf60aced7882a7f962eecd743efd2a91

[Jialiu Lin, 2017-04-12 00:25:55]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 00:26:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jialiu Lin, 2017-04-12 17:41:00]

jialiul@chromium.org changed reviewers:
+ lpz@chromium.org

[Jialiu Lin, 2017-04-12 17:41:00]

lpz@,
Could you take a look at this CL? Thanks!

[lpz, 2017-04-12 18:45:22]

lgtm

https://codereview.chromium.org/2813063003/diff/20001/components/safe_browsin...
File components/safe_browsing/csd.proto (right):

https://codereview.chromium.org/2813063003/diff/20001/components/safe_browsin...
components/safe_browsing/csd.proto:252: optional bool
cache_expression_exact_match = 4;
rename DEPRECATED_cache_expression_exact_match to find referencing code?

[vakh (use Gerrit instead), 2017-04-12 18:46:47]

vakh@chromium.org changed reviewers:
+ vakh@chromium.org

[vakh (use Gerrit instead), 2017-04-12 18:46:48]

I would recommend adding a detailed explanation of why it is being deprecated.

[Jialiu Lin, 2017-04-12 19:21:23]

Description was changed from

==========
Deprecate cache_expression_exact_match

Deprecate cache_expression_exact_match proto field in LoginRepurationResponse,
and remove its related matching logic and tests.

BUG=698899
==========

to

==========
Deprecate cache_expression_exact_match

Deprecate cache_expression_exact_match proto field in LoginRepurationResponse,
and remove its related matching logic and tests.

After looking closer at the site_chunk rules, we a simple boolean
cache_expression_exact_match field is not enough for some corner cases.
Therefore, we proposed to make the backend compute the most appropriate
cache_expression for all the corner cases (instead of handling complex logic in
client.)  go/cache_expression_matching

BUG=698899
==========

[Jialiu Lin, 2017-04-12 19:22:09]

Description was changed from

==========
Deprecate cache_expression_exact_match

Deprecate cache_expression_exact_match proto field in LoginRepurationResponse,
and remove its related matching logic and tests.

After looking closer at the site_chunk rules, we a simple boolean
cache_expression_exact_match field is not enough for some corner cases.
Therefore, we proposed to make the backend compute the most appropriate
cache_expression for all the corner cases (instead of handling complex logic in
client.)  go/cache_expression_matching

BUG=698899
==========

to

==========
Deprecate cache_expression_exact_match

Deprecate cache_expression_exact_match proto field in LoginRepurationResponse,
and remove its related matching logic and tests.

After looking closer at the site_chunk rules, using a
simple boolean cache_expression_exact_match field is 
not enough for some corner cases. Therefore, we
proposed to make the backend compute the most
appropriate cache_expression for all the corner cases
(instead of handling complex logic in client.) 
go/cache_expression_matching

BUG=698899
==========

[Jialiu Lin, 2017-04-12 19:22:43]

Description was changed from

==========
Deprecate cache_expression_exact_match

Deprecate cache_expression_exact_match proto field in LoginRepurationResponse,
and remove its related matching logic and tests.

After looking closer at the site_chunk rules, using a
simple boolean cache_expression_exact_match field is 
not enough for some corner cases. Therefore, we
proposed to make the backend compute the most
appropriate cache_expression for all the corner cases
(instead of handling complex logic in client.) 
go/cache_expression_matching

BUG=698899
==========

to

==========
Deprecate cache_expression_exact_match

Deprecate cache_expression_exact_match proto field in
LoginRepurationResponse, and remove its related matching
logic and tests.

After looking closer at the site_chunk rules, using a
simple boolean cache_expression_exact_match field is 
not enough for some corner cases. Therefore, we
proposed to make the backend compute the most
appropriate cache_expression for all the corner cases
(instead of handling complex logic in client.) 
go/cache_expression_matching

BUG=698899
==========

[Jialiu Lin, 2017-04-12 19:33:17]

Hi lpz@ and vakh@,
Thanks for your review! I have updated this CL description to explain why this
proto field is deprecated.

https://codereview.chromium.org/2813063003/diff/20001/components/safe_browsin...
File components/safe_browsing/csd.proto (right):

https://codereview.chromium.org/2813063003/diff/20001/components/safe_browsin...
components/safe_browsing/csd.proto:252: optional bool
cache_expression_exact_match = 4;
On 2017/04/12 18:45:21, lpz wrote:
> rename DEPRECATED_cache_expression_exact_match to find referencing code?

Done. Also added "[deprecated = true]"

[Jialiu Lin, 2017-04-12 20:23:03]

The CQ bit was checked by jialiul@chromium.org

[Jialiu Lin, 2017-04-12 20:23:03]

The patchset sent to the CQ was uploaded after l-g-t-m from lpz@chromium.org
Link to the patchset: https://codereview.chromium.org/2813063003/#ps40001
(title: "refine deprecated field")

[commit-bot: I haz the power, 2017-04-12 20:23:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 01:02:13]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492028583543370,
"parent_rev": "b4c0c2e4cc6238aebf284748213b22986bd1510a", "commit_rev":
"eb38d9eecf60aced7882a7f962eecd743efd2a91"}

[commit-bot: I haz the power, 2017-04-13 01:03:08]

Description was changed from

==========
Deprecate cache_expression_exact_match

Deprecate cache_expression_exact_match proto field in
LoginRepurationResponse, and remove its related matching
logic and tests.

After looking closer at the site_chunk rules, using a
simple boolean cache_expression_exact_match field is 
not enough for some corner cases. Therefore, we
proposed to make the backend compute the most
appropriate cache_expression for all the corner cases
(instead of handling complex logic in client.) 
go/cache_expression_matching

BUG=698899
==========

to

==========
Deprecate cache_expression_exact_match

Deprecate cache_expression_exact_match proto field in
LoginRepurationResponse, and remove its related matching
logic and tests.

After looking closer at the site_chunk rules, using a
simple boolean cache_expression_exact_match field is 
not enough for some corner cases. Therefore, we
proposed to make the backend compute the most
appropriate cache_expression for all the corner cases
(instead of handling complex logic in client.) 
go/cache_expression_matching

BUG=698899

Review-Url: https://codereview.chromium.org/2813063003
Cr-Commit-Position: refs/heads/master@{#464225}
Committed:
https://chromium.googlesource.com/chromium/src/+/eb38d9eecf60aced7882a7f962ee...
==========

[commit-bot: I haz the power, 2017-04-13 01:03:09]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/eb38d9eecf60aced7882a7f962ee...