Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2813063002: cc: Remove SanityCheckState from software image cache. (Closed)

Created:
3 years, 8 months ago by vmpstr
Modified:
3 years, 8 months ago
Reviewers:
ericrk
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove SanityCheckState from software image cache. SanityCheckState is a pretty heavy function and it hasn't been useful in a long time (since we've ironed out the bugs in the cache). Although this is only run in DCHECK builds, I'd still like to remove it so that when dchecks are on we get better performance out of the software caches. R=ericrk@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2813063002 Cr-Commit-Position: refs/heads/master@{#464160} Committed: https://chromium.googlesource.com/chromium/src/+/ae8e1bba3b31aa540ad7684e75374d193946d4e2

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -46 lines) Patch
M cc/tiles/software_image_decode_cache.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/tiles/software_image_decode_cache.cc View 1 11 chunks +1 line, -45 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
vmpstr
Please take a look.
3 years, 8 months ago (2017-04-12 00:02:25 UTC) #2
ericrk
lgtm
3 years, 8 months ago (2017-04-12 18:06:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813063002/20001
3 years, 8 months ago (2017-04-12 19:00:31 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 21:48:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ae8e1bba3b31aa540ad7684e7537...

Powered by Google App Engine
This is Rietveld 408576698