Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2813053002: MD Settings: Internet: Cellular: Add data roaming toggle (Closed)

Created:
3 years, 8 months ago by stevenjb
Modified:
3 years, 8 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, extensions-reviews_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-settings_chromium.org, srahim+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Internet: Cellular: Add data roaming toggle Add the 'Allow data roaming' toggle to the Cellular details page. Even though this is an owner controlled device pref not associated with a specific network, we only support one Cellular network and the preference only applies when a Cellular network is avaliable, so the Cellular details page is the most logical place for it. BUG=699968 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2813053002 Cr-Commit-Position: refs/heads/master@{#463890} Committed: https://chromium.googlesource.com/chromium/src/+/eda9cdcabdd8c4ca8eb400e7804f33d98106ec34

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M chrome/app/settings_strings.grdp View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/settings_private/prefs_util.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_detail_page.html View 1 4 chunks +13 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
stevenjb
3 years, 8 months ago (2017-04-11 23:26:01 UTC) #3
michaelpg
lgtm
3 years, 8 months ago (2017-04-12 00:20:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813053002/20001
3 years, 8 months ago (2017-04-12 00:40:25 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 01:51:00 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/eda9cdcabdd8c4ca8eb400e7804f...

Powered by Google App Engine
This is Rietveld 408576698