Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 2813043003: Fix ChromeDriver cannot focus element error (Closed)

Created:
3 years, 8 months ago by johnchen
Modified:
3 years, 8 months ago
Reviewers:
stgao
CC:
chromium-reviews, samuong+watch_chromium.org, gmanikpure
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ChromeDriver cannot focus element error When ChromeDriver sets focus on an element, a descendant node of that element may receive the focus instead. Modifying ChromeDriver code to handle such a case. Review-Url: https://codereview.chromium.org/2813043003 Cr-Commit-Position: refs/heads/master@{#464401} Committed: https://chromium.googlesource.com/chromium/src/+/46a3e827492e88cfd3728265c7f1d4475392fb5c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/test/chromedriver/js/focus.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
johnchen
This CL fixes internal bug http://b/31860737, which interferes with ChromeDriver's ability to focus on an ...
3 years, 8 months ago (2017-04-12 21:11:38 UTC) #2
stgao
lgtm
3 years, 8 months ago (2017-04-13 03:54:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813043003/1
3 years, 8 months ago (2017-04-13 14:29:59 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 14:41:58 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/46a3e827492e88cfd3728265c7f1...

Powered by Google App Engine
This is Rietveld 408576698