Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 281303003: Generate gm/Android.mk, minus JSON. (Closed)

Created:
6 years, 7 months ago by scroggo
Modified:
6 years, 7 months ago
Reviewers:
epoger
CC:
skia-review_googlegroups.com, djsollen
Base URL:
https://skia.googlesource.com/skia.git@baseline_gm
Visibility:
Public.

Description

Generate gm/Android.mk, minus JSON. When running gyp_to_android.py, generate the makefile for gm. For now, remove json functionality and do not depend on json. This allows us to build and run until solving skbug.com/2448. gm/gm_expectations.cpp: gm/gm_expectations.h: gm/gmmain.cpp: Remove all json functionality when SK_BUILD_JSON_WRITER is not defined. This flag is not defined when SK_BUILD_FOR_ANDROID is defined. gyp/gm.gyp: Depend on skia and cutils. platform_tools/android/bin/gyp_to_android.py: Generate gm/Android.mk. platform_tools/android/gyp_gen/makefile_writer.py: Build gm/Android.mk when building external/skia. Depends on https://codereview.chromium.org/282053002/ BUG=skia:2447 BUG=skia:2448 Committed: http://code.google.com/p/skia/source/detail?r=14767

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updates in response to https://codereview.chromium.org/282053002/ #

Patch Set 3 : Remove generated files. #

Patch Set 4 : Remove one more generated file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -6 lines) Patch
M gm/gm_expectations.h View 1 8 chunks +12 lines, -1 line 0 comments Download
M gm/gm_expectations.cpp View 1 12 chunks +12 lines, -3 lines 0 comments Download
M gm/gmmain.cpp View 1 8 chunks +12 lines, -1 line 0 comments Download
M gyp/gm.gyp View 1 1 chunk +6 lines, -0 lines 0 comments Download
M platform_tools/android/bin/gyp_to_android.py View 1 chunk +8 lines, -0 lines 0 comments Download
M platform_tools/android/gyp_gen/makefile_writer.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
scroggo
Elliot, sorry to be so invasive on your gm files! I hope to ultimately get ...
6 years, 7 months ago (2014-05-14 21:20:02 UTC) #1
epoger
lgtm
6 years, 7 months ago (2014-05-14 21:36:12 UTC) #2
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 7 months ago (2014-05-16 17:47:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/281303003/60001
6 years, 7 months ago (2014-05-16 17:48:06 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 17:56:46 UTC) #5
Message was sent while issue was closed.
Change committed as 14767

Powered by Google App Engine
This is Rietveld 408576698