Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: gm/gm_expectations.h

Issue 281303003: Generate gm/Android.mk, minus JSON. (Closed) Base URL: https://skia.googlesource.com/skia.git@baseline_gm
Patch Set: Remove one more generated file Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gm/gm_expectations.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/gm_expectations.h
diff --git a/gm/gm_expectations.h b/gm/gm_expectations.h
index 70921273380ab8b13cf609ff739cdb466fbd322b..8d986f0847f1db39efa96ddf9e122dd2aa6b8552 100644
--- a/gm/gm_expectations.h
+++ b/gm/gm_expectations.h
@@ -22,12 +22,13 @@
namespace skiagm {
+#ifdef SK_BUILD_JSON_WRITER
Json::Value CreateJsonTree(Json::Value expectedResults,
Json::Value actualResultsFailed,
Json::Value actualResultsFailureIgnored,
Json::Value actualResultsNoComparison,
Json::Value actualResultsSucceeded);
-
+#endif
/**
* The digest of a GM test result.
*
@@ -41,12 +42,14 @@ namespace skiagm {
*/
explicit GmResultDigest(const SkBitmap &bitmap);
+#ifdef SK_BUILD_JSON_WRITER
/**
* Create a ResultDigest representing an allowed result
* checksum within JSON expectations file, in the form
* ["bitmap-64bitMD5", 12345].
*/
explicit GmResultDigest(const Json::Value &jsonTypeValuePair);
+#endif
/**
* Returns true if this GmResultDigest was fully and successfully
@@ -60,11 +63,13 @@ namespace skiagm {
*/
bool equals(const GmResultDigest &other) const;
+#ifdef SK_BUILD_JSON_WRITER
/**
* Returns a JSON type/value pair representing this result,
* such as ["bitmap-64bitMD5", 12345].
*/
Json::Value asJsonTypeValuePair() const;
+#endif
/**
* Returns the hashtype, such as "bitmap-64bitMD5", as an SkString.
@@ -113,6 +118,7 @@ namespace skiagm {
*/
explicit Expectations(const BitmapAndDigest& bitmapAndDigest);
+#ifdef SK_BUILD_JSON_WRITER
/**
* Create Expectations from a JSON element as found within the
* kJsonKey_ExpectedResults section.
@@ -121,6 +127,7 @@ namespace skiagm {
* don't have any expectations.
*/
explicit Expectations(Json::Value jsonElement);
+#endif
/**
* Returns true iff we want to ignore failed expectations.
@@ -154,10 +161,12 @@ namespace skiagm {
return (SkBitmap::kNo_Config == fBitmap.config()) ? NULL : &fBitmap;
}
+#ifdef SK_BUILD_JSON_WRITER
/**
* Return a JSON representation of the expectations.
*/
Json::Value asJsonValue() const;
+#endif
private:
const static bool kDefaultIgnoreFailure = false;
@@ -200,6 +209,7 @@ namespace skiagm {
const SkString fRootDir;
};
+#ifdef SK_BUILD_JSON_WRITER
/**
* Return Expectations based on JSON summary file.
*/
@@ -227,6 +237,7 @@ namespace skiagm {
Json::Value fJsonRoot;
Json::Value fJsonExpectedResults;
};
+#endif // SK_BUILD_JSON_WRITER
}
#endif
« no previous file with comments | « no previous file | gm/gm_expectations.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698