Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 2813023003: Removes YouTube app id constant (Closed)

Created:
3 years, 8 months ago by pkl (ping after 24h if needed)
Modified:
3 years, 8 months ago
Reviewers:
lpromero
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes YouTube app id constant This is the upstream portion of https://chromereviews.googleplex.com/583857013 After downstream portion is submitted, no one will be using these contants. BUG=710069 Review-Url: https://codereview.chromium.org/2813023003 Cr-Commit-Position: refs/heads/master@{#464248} Committed: https://chromium.googlesource.com/chromium/src/+/3dbb47353998ea483fdea2ff2bd3584d0a25c0f1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M ios/chrome/browser/native_app_launcher/ios_appstore_ids.h View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/native_app_launcher/ios_appstore_ids.mm View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
pkl (ping after 24h if needed)
This needs to land *after* https://chromereviews.googleplex.com/583857013/
3 years, 8 months ago (2017-04-12 01:14:08 UTC) #2
lpromero
lgtm
3 years, 8 months ago (2017-04-12 09:03:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813023003/1
3 years, 8 months ago (2017-04-13 00:29:41 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 02:25:41 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3dbb47353998ea483fdea2ff2bd3...

Powered by Google App Engine
This is Rietveld 408576698