[Bindings] Make maplike<> and setlike<> imply a readonly size attribute.

[Bindings] Make maplike<> and setlike<> imply a readonly size attribute.

This required implementing one for RTCStatsReport, which is presently missing
it.

This also replaces the size attribute on FontFaceSet, MIDIInputMap and
MIDIOutputMap with one generated according to the WebIDL rules for maplike<>
and setlike<>.

Because the spec specifies that this property is not enumerable, this has the
side effect of making it non-enumerable on the interfaces that already define
it explicitly.

BUG=697121
TBR=tommyw@chromium.org

Review-Url: https://codereview.chromium.org/2813023002
Cr-Commit-Position: refs/heads/master@{#464501}
Committed: https://chromium.googlesource.com/chromium/src/+/3ca2419cbb0dc16043535a1ec1e04b4977e725c1

[jbroman, 2017-04-11 21:31:43]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 21:32:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbroman, 2017-04-11 21:32:49]

Description was changed from

==========
[Bindings] Make maplike<> and setlike<> imply a readonly size attribute.

This required implementing one for RTCStatsReport, which is presently missing
it.

BUG=697121
==========

to

==========
[Bindings] Make maplike<> and setlike<> imply a readonly size attribute.

This required implementing one for RTCStatsReport, which is presently missing
it.

Because the spec specifies that this property is not enumerable, this has the
side effect of making it non-enumerable on the interfaces that already define
it explicitly.

BUG=697121
==========

[commit-bot: I haz the power, 2017-04-11 23:04:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 23:04:15]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[jbroman, 2017-04-11 23:33:57]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 23:34:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 01:19:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 01:19:46]

Dry run: This issue passed the CQ dry run.

[jbroman, 2017-04-12 15:36:03]

jbroman@chromium.org changed reviewers:
+ bashi@chromium.org, foolip@chromium.org, hbos@chromium.org

[jbroman, 2017-04-12 15:36:03]

+bashi for bindings
+hbos for WebRTC (content/renderer/media/, WebRTCStats.h,
modules/peerconnection/)
+foolip for layout test changes (this seems pretty trivial, but I can send an
Intent to Implement and Ship if you'd prefer)

I've generated one that calls "size" (since most objects already have that), but
I could add ImplementedAs=sizeForBindings for consistency with some of the other
methods, if you prefer.

[jbroman, 2017-04-12 15:36:32]

jbroman@chromium.org changed reviewers:
+ toyoshim@chromium.org

[jbroman, 2017-04-12 15:36:32]

Oh, I also need a modules/webmidi/ OWNER. +toyoshim

[foolip, 2017-04-12 17:25:23]

third_party/WebKit/LayoutTests/ lgtm, very minor and I wouldn't want to send an
intent if making the change myself :)

[bashi, 2017-04-12 23:08:33]

bindings/ lgtm. I'd prefer this approach than adding an extended attribute :)

[haraken, 2017-04-12 23:44:19]

LGTM

[Takashi Toyoshima, 2017-04-13 03:27:44]

Thanks, webmidi LGTM.

Can you modify CL description to say this patch also fix existing wrong
implementation of MIDIInputMap.size and MIDIOutputMap.size?

[hbos_chromium, 2017-04-13 10:58:16]

lgtm

[jbroman, 2017-04-13 14:24:31]

Description was changed from

==========
[Bindings] Make maplike<> and setlike<> imply a readonly size attribute.

This required implementing one for RTCStatsReport, which is presently missing
it.

Because the spec specifies that this property is not enumerable, this has the
side effect of making it non-enumerable on the interfaces that already define
it explicitly.

BUG=697121
==========

to

==========
[Bindings] Make maplike<> and setlike<> imply a readonly size attribute.

This required implementing one for RTCStatsReport, which is presently missing
it.

Because the spec specifies that this property is not enumerable, this has the
side effect of making it non-enumerable on the interfaces that already define
it explicitly.

This also replaces the size attribute on FontFaceSet, MIDIInputMap and
MIDIOutputMap with one generated according to the WebIDL rules for maplike<>
and setlike<>.

BUG=697121
==========

[jbroman, 2017-04-13 14:24:31]

jbroman@chromium.org changed reviewers:
+ haraken@chromium.org

[jbroman, 2017-04-13 14:24:44]

Description was changed from

==========
[Bindings] Make maplike<> and setlike<> imply a readonly size attribute.

This required implementing one for RTCStatsReport, which is presently missing
it.

Because the spec specifies that this property is not enumerable, this has the
side effect of making it non-enumerable on the interfaces that already define
it explicitly.

This also replaces the size attribute on FontFaceSet, MIDIInputMap and
MIDIOutputMap with one generated according to the WebIDL rules for maplike<>
and setlike<>.

BUG=697121
==========

to

==========
[Bindings] Make maplike<> and setlike<> imply a readonly size attribute.

This required implementing one for RTCStatsReport, which is presently missing
it.

This also replaces the size attribute on FontFaceSet, MIDIInputMap and
MIDIOutputMap with one generated according to the WebIDL rules for maplike<>
and setlike<>.

Because the spec specifies that this property is not enumerable, this has the
side effect of making it non-enumerable on the interfaces that already define
it explicitly.

BUG=697121
==========

[jbroman, 2017-04-13 14:24:59]

On 2017/04/13 at 03:27:44, toyoshim wrote:
> Thanks, webmidi LGTM.
> 
> Can you modify CL description to say this patch also fix existing wrong
implementation of MIDIInputMap.size and MIDIOutputMap.size?

Explicitly called out the interfaces whose attributes were replaced in this way.

[jbroman, 2017-04-13 14:25:04]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2017-04-13 14:25:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 14:34:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 14:34:11]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jbroman, 2017-04-13 14:37:27]

Description was changed from

==========
[Bindings] Make maplike<> and setlike<> imply a readonly size attribute.

This required implementing one for RTCStatsReport, which is presently missing
it.

This also replaces the size attribute on FontFaceSet, MIDIInputMap and
MIDIOutputMap with one generated according to the WebIDL rules for maplike<>
and setlike<>.

Because the spec specifies that this property is not enumerable, this has the
side effect of making it non-enumerable on the interfaces that already define
it explicitly.

BUG=697121
==========

to

==========
[Bindings] Make maplike<> and setlike<> imply a readonly size attribute.

This required implementing one for RTCStatsReport, which is presently missing
it.

This also replaces the size attribute on FontFaceSet, MIDIInputMap and
MIDIOutputMap with one generated according to the WebIDL rules for maplike<>
and setlike<>.

Because the spec specifies that this property is not enumerable, this has the
side effect of making it non-enumerable on the interfaces that already define
it explicitly.

BUG=697121
TBR=tommyw@chromium.org
==========

[jbroman, 2017-04-13 14:37:39]

The CQ bit was checked by jbroman@chromium.org

[jbroman, 2017-04-13 14:37:40]

TBR-ing the one-line change to test_runner

[commit-bot: I haz the power, 2017-04-13 14:37:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbroman, 2017-04-13 17:05:21]

The CQ bit was unchecked by jbroman@chromium.org

[jbroman, 2017-04-13 17:08:03]

The CQ bit was checked by jbroman@chromium.org

[jbroman, 2017-04-13 17:08:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, toyoshim@chromium.org, hbos@chromium.org,
foolip@chromium.org, bashi@chromium.org
Link to the patchset: https://codereview.chromium.org/2813023002/#ps40001
(title: "merge with 23752147e6f5f7dcaf4bad1bb1c306fb91e1ec5b")

[commit-bot: I haz the power, 2017-04-13 17:08:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 19:26:39]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492103283338710,
"parent_rev": "70df80adfac5d24b6ade4507b919e05df88ab029", "commit_rev":
"3ca2419cbb0dc16043535a1ec1e04b4977e725c1"}

[commit-bot: I haz the power, 2017-04-13 19:27:36]

Description was changed from

==========
[Bindings] Make maplike<> and setlike<> imply a readonly size attribute.

This required implementing one for RTCStatsReport, which is presently missing
it.

This also replaces the size attribute on FontFaceSet, MIDIInputMap and
MIDIOutputMap with one generated according to the WebIDL rules for maplike<>
and setlike<>.

Because the spec specifies that this property is not enumerable, this has the
side effect of making it non-enumerable on the interfaces that already define
it explicitly.

BUG=697121
TBR=tommyw@chromium.org
==========

to

==========
[Bindings] Make maplike<> and setlike<> imply a readonly size attribute.

This required implementing one for RTCStatsReport, which is presently missing
it.

This also replaces the size attribute on FontFaceSet, MIDIInputMap and
MIDIOutputMap with one generated according to the WebIDL rules for maplike<>
and setlike<>.

Because the spec specifies that this property is not enumerable, this has the
side effect of making it non-enumerable on the interfaces that already define
it explicitly.

BUG=697121
TBR=tommyw@chromium.org

Review-Url: https://codereview.chromium.org/2813023002
Cr-Commit-Position: refs/heads/master@{#464501}
Committed:
https://chromium.googlesource.com/chromium/src/+/3ca2419cbb0dc16043535a1ec1e0...
==========

[commit-bot: I haz the power, 2017-04-13 19:27:38]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3ca2419cbb0dc16043535a1ec1e0...