Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2813023002: [Bindings] Make maplike<> and setlike<> imply a readonly size attribute. (Closed)

Created:
3 years, 8 months ago by jbroman
Modified:
3 years, 8 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-bindings_chromium.org, blink-reviews-css, chfremer+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, feature-media-reviews_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org, Peter Beverloo, posciak+watch_chromium.org, rwlbuis, toyoshim+midi_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Bindings] Make maplike<> and setlike<> imply a readonly size attribute. This required implementing one for RTCStatsReport, which is presently missing it. This also replaces the size attribute on FontFaceSet, MIDIInputMap and MIDIOutputMap with one generated according to the WebIDL rules for maplike<> and setlike<>. Because the spec specifies that this property is not enumerable, this has the side effect of making it non-enumerable on the interfaces that already define it explicitly. BUG=697121 TBR=tommyw@chromium.org Review-Url: https://codereview.chromium.org/2813023002 Cr-Commit-Position: refs/heads/master@{#464501} Committed: https://chromium.googlesource.com/chromium/src/+/3ca2419cbb0dc16043535a1ec1e04b4977e725c1

Patch Set 1 #

Patch Set 2 : expectations #

Patch Set 3 : merge with 23752147e6f5f7dcaf4bad1bb1c306fb91e1ec5b #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -11 lines) Patch
M content/renderer/media/webrtc/rtc_stats.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/webrtc/rtc_stats.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/shell/test_runner/mock_webrtc_peer_connection_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_interface.py View 1 2 3 chunks +41 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.cpp View 1 2 4 chunks +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp View 1 2 3 chunks +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 1 2 3 chunks +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFaceSet.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCStatsReport.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIInputMap.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIOutputMap.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebRTCStats.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 37 (23 generated)
jbroman
+bashi for bindings +hbos for WebRTC (content/renderer/media/, WebRTCStats.h, modules/peerconnection/) +foolip for layout test changes (this ...
3 years, 8 months ago (2017-04-12 15:36:03 UTC) #11
jbroman
Oh, I also need a modules/webmidi/ OWNER. +toyoshim
3 years, 8 months ago (2017-04-12 15:36:32 UTC) #13
foolip
third_party/WebKit/LayoutTests/ lgtm, very minor and I wouldn't want to send an intent if making the ...
3 years, 8 months ago (2017-04-12 17:25:23 UTC) #14
bashi
bindings/ lgtm. I'd prefer this approach than adding an extended attribute :)
3 years, 8 months ago (2017-04-12 23:08:33 UTC) #15
haraken
LGTM
3 years, 8 months ago (2017-04-12 23:44:19 UTC) #16
Takashi Toyoshima
Thanks, webmidi LGTM. Can you modify CL description to say this patch also fix existing ...
3 years, 8 months ago (2017-04-13 03:27:44 UTC) #17
hbos_chromium
lgtm
3 years, 8 months ago (2017-04-13 10:58:16 UTC) #18
jbroman
On 2017/04/13 at 03:27:44, toyoshim wrote: > Thanks, webmidi LGTM. > > Can you modify ...
3 years, 8 months ago (2017-04-13 14:24:59 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813023002/20001
3 years, 8 months ago (2017-04-13 14:25:18 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/410434)
3 years, 8 months ago (2017-04-13 14:34:11 UTC) #26
jbroman
TBR-ing the one-line change to test_runner
3 years, 8 months ago (2017-04-13 14:37:40 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813023002/20001
3 years, 8 months ago (2017-04-13 14:37:56 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813023002/40001
3 years, 8 months ago (2017-04-13 17:08:33 UTC) #34
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 19:27:38 UTC) #37
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3ca2419cbb0dc16043535a1ec1e0...

Powered by Google App Engine
This is Rietveld 408576698