Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2812983005: Revert some jumplist function names (Closed)

Created:
3 years, 8 months ago by chengx
Modified:
3 years, 8 months ago
Reviewers:
gab
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert some jumplist function names In crrev.com/2811003002, some methods were renamed which they shouldn't. This CL changes them back. BUG=40407, 179576 Review-Url: https://codereview.chromium.org/2812983005 Cr-Commit-Position: refs/heads/master@{#464418} Committed: https://chromium.googlesource.com/chromium/src/+/6ea1b0eef2438b8365c3b762b6e545b08e1a27ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -20 lines) Patch
M chrome/browser/win/jumplist.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/win/jumplist.cc View 4 chunks +10 lines, -13 lines 0 comments Download
M chrome/browser/win/jumplist_file_util.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/win/jumplist_file_util.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
chengx
Reverting the function names per request. PTAL, THANKS!
3 years, 8 months ago (2017-04-12 21:43:10 UTC) #5
gab
lgtm
3 years, 8 months ago (2017-04-13 15:32:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812983005/1
3 years, 8 months ago (2017-04-13 15:33:16 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 15:40:17 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6ea1b0eef2438b8365c3b762b6e5...

Powered by Google App Engine
This is Rietveld 408576698