Change NGLayoutOpportunityIterator API to work with list of exclusions

Change NGLayoutOpportunityIterator API to work with list of exclusions

This updates NGLayoutOpportunityIterator API so it starts accepting
the list of exclusions instead of constraint space.

We need this API to implement the logic that will search for layout
opportunities to place a BFC block while we have some placement
pending floats.

BUG=635619
Review-Url: https://codereview.chromium.org/2812983002
Cr-Commit-Position: refs/heads/master@{#464746}
Committed: https://chromium.googlesource.com/chromium/src/+/1cabd22b2e8ee5e4ff1fd679bbb73c0b2542d405

[Gleb Lanbin, 2017-04-11 19:11:57]

Description was changed from

==========
Change NGLayoutOpportunityIterator API to work with list of exclusions

This updates NGLayoutOpportunityIterator API so it starts accepting
the list of exclusions instead of constraint space.

We need this API to implement the logic that will search for layout
opportunities to place a BFC block while we have some placement
pending floats.

BUG=635619
==========

to

==========
Change NGLayoutOpportunityIterator API to work with list of exclusions

This updates NGLayoutOpportunityIterator API so it starts accepting
the list of exclusions instead of constraint space.

We need this API to implement the logic that will search for layout
opportunities to place a BFC block while we have some placement
pending floats.

BUG=635619
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[Gleb Lanbin, 2017-04-11 19:12:19]

glebl@chromium.org changed reviewers:
+ ikilpatrick@chromium.org

[Gleb Lanbin, 2017-04-11 19:17:07]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 19:17:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Gleb Lanbin, 2017-04-11 19:31:10]

Patchset #1 (id:1) has been deleted

[Gleb Lanbin, 2017-04-11 19:31:27]

Patchset #1 (id:20001) has been deleted

[Gleb Lanbin, 2017-04-11 19:31:36]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 19:32:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cbiesinger, 2017-04-11 20:09:38]

cbiesinger@chromium.org changed reviewers:
+ cbiesinger@chromium.org

[cbiesinger, 2017-04-11 20:09:39]

https://codereview.chromium.org/2812983002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc (right):

https://codereview.chromium.org/2812983002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc:145:
this->Exclusions().get(), AvailableSize(), iter_offset);
why the this->?

[Gleb Lanbin, 2017-04-11 20:21:38]

PTAL

https://codereview.chromium.org/2812983002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc (right):

https://codereview.chromium.org/2812983002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc:145:
this->Exclusions().get(), AvailableSize(), iter_offset);
On 2017/04/11 20:09:38, cbiesinger wrote:
> why the this->?

Done.

[Gleb Lanbin, 2017-04-11 20:21:46]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 20:22:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 22:27:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 22:27:21]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_layout_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[ikilpatrick, 2017-04-14 10:40:58]

lgtm

[Gleb Lanbin, 2017-04-14 14:44:43]

Description was changed from

==========
Change NGLayoutOpportunityIterator API to work with list of exclusions

This updates NGLayoutOpportunityIterator API so it starts accepting
the list of exclusions instead of constraint space.

We need this API to implement the logic that will search for layout
opportunities to place a BFC block while we have some placement
pending floats.

BUG=635619
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
Change NGLayoutOpportunityIterator API to work with list of exclusions

This updates NGLayoutOpportunityIterator API so it starts accepting
the list of exclusions instead of constraint space.

We need this API to implement the logic that will search for layout
opportunities to place a BFC block while we have some placement
pending floats.

BUG=635619
==========

[Gleb Lanbin, 2017-04-14 14:44:48]

The CQ bit was checked by glebl@chromium.org

[commit-bot: I haz the power, 2017-04-14 14:44:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 14:47:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 14:47:50]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Gleb Lanbin, 2017-04-14 15:38:37]

The CQ bit was checked by glebl@chromium.org

[Gleb Lanbin, 2017-04-14 15:38:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
ikilpatrick@chromium.org
Link to the patchset: https://codereview.chromium.org/2812983002/#ps80001
(title: "git rebase-update")

[commit-bot: I haz the power, 2017-04-14 15:38:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 17:25:39]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1492184317611050,
"parent_rev": "91a7ec0dd668d833a3f580ea8596407c14b1476f", "commit_rev":
"1cabd22b2e8ee5e4ff1fd679bbb73c0b2542d405"}

[commit-bot: I haz the power, 2017-04-14 17:26:26]

Description was changed from

==========
Change NGLayoutOpportunityIterator API to work with list of exclusions

This updates NGLayoutOpportunityIterator API so it starts accepting
the list of exclusions instead of constraint space.

We need this API to implement the logic that will search for layout
opportunities to place a BFC block while we have some placement
pending floats.

BUG=635619
==========

to

==========
Change NGLayoutOpportunityIterator API to work with list of exclusions

This updates NGLayoutOpportunityIterator API so it starts accepting
the list of exclusions instead of constraint space.

We need this API to implement the logic that will search for layout
opportunities to place a BFC block while we have some placement
pending floats.

BUG=635619

Review-Url: https://codereview.chromium.org/2812983002
Cr-Commit-Position: refs/heads/master@{#464746}
Committed:
https://chromium.googlesource.com/chromium/src/+/1cabd22b2e8ee5e4ff1fd679bbb7...
==========

[commit-bot: I haz the power, 2017-04-14 17:26:28]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/1cabd22b2e8ee5e4ff1fd679bbb7...