Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2812963003:
Add DrawingBuffer multisample resolve unit test. (Closed)
|
Created:
3 years, 8 months ago by capn Modified:
3 years, 8 months ago Reviewers:
Justin Novosad CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, kinuko+watch, pdr+graphicswatchlist_chromium.org, piman+watch_chromium.org, rwlbuis, Stephen Chennney Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd DrawingBuffer multisample resolve unit test.
BUG=707298
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I171c9b733d735f8a035640fd96b8fda5dd7686ec
Review-Url: https://codereview.chromium.org/2812963003
Cr-Commit-Position: refs/heads/master@{#464370}
Committed: https://chromium.googlesource.com/chromium/src/+/a4e71644c28270d794f1413b69e5e0efdfe79ab6
Patch Set 1 #Patch Set 2 : Add MarkContentsChanged() expectations. #Patch Set 3 : Fix DrawingBufferSoftwareRenderingTest. #Patch Set 4 : Fix leak. #
Total comments: 1
Patch Set 5 : Use enum. #
Messages
Total messages: 30 (24 generated)
The CQ bit was checked by capn@chromium.org to run a CQ dry run
The CQ bit was unchecked by capn@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Add DrawingBuffer multisample resolve unit test. BUG=707298 Change-Id: I171c9b733d735f8a035640fd96b8fda5dd7686ec ========== to ========== Add DrawingBuffer multisample resolve unit test. BUG=707298 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I171c9b733d735f8a035640fd96b8fda5dd7686ec ==========
The CQ bit was checked by capn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by capn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
capn@chromium.org changed reviewers: + junov@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by capn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2812963003/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTestHelpers.h (right): https://codereview.chromium.org/2812963003/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTestHelpers.h:28: bool multisample_extension_supported) { Use an enum instead of a bool here. It's rule #10 of the blink style guide: https://sites.google.com/a/chromium.org/dev/blink/coding-style
The CQ bit was checked by capn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/04/12 at 19:22:15, junov wrote: > https://codereview.chromium.org/2812963003/diff/60001/third_party/WebKit/Sour... > File third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTestHelpers.h (right): > > https://codereview.chromium.org/2812963003/diff/60001/third_party/WebKit/Sour... > third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTestHelpers.h:28: bool multisample_extension_supported) { > Use an enum instead of a bool here. It's rule #10 of the blink style guide: https://sites.google.com/a/chromium.org/dev/blink/coding-style Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by capn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1492079887563210,
"parent_rev": "38f632c6f3b0a78b5ee961e02ac7a333877cfbe5", "commit_rev":
"a4e71644c28270d794f1413b69e5e0efdfe79ab6"}
Message was sent while issue was closed.
Description was changed from ========== Add DrawingBuffer multisample resolve unit test. BUG=707298 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I171c9b733d735f8a035640fd96b8fda5dd7686ec ========== to ========== Add DrawingBuffer multisample resolve unit test. BUG=707298 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I171c9b733d735f8a035640fd96b8fda5dd7686ec Review-Url: https://codereview.chromium.org/2812963003 Cr-Commit-Position: refs/heads/master@{#464370} Committed: https://chromium.googlesource.com/chromium/src/+/a4e71644c28270d794f1413b69e5... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/a4e71644c28270d794f1413b69e5... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
