Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4256)

Unified Diff: chrome/browser/ui/webui/system_info_ui.cc

Issue 2812953002: Stop passing raw pointers to base::Value API in c/b/ui (Closed)
Patch Set: No ListValue::SetDouble Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/system_info_ui.cc
diff --git a/chrome/browser/ui/webui/system_info_ui.cc b/chrome/browser/ui/webui/system_info_ui.cc
index 1c14d01b58cef892c7015c9b314163b8739073a6..ebf7121cc532d4286b6a95240e271c6a7c7ade9d 100644
--- a/chrome/browser/ui/webui/system_info_ui.cc
+++ b/chrome/browser/ui/webui/system_info_ui.cc
@@ -152,8 +152,7 @@ void SystemInfoUIHTMLSource::RequestComplete() {
webui::SetLoadTimeDataDefaults(app_locale, &strings);
if (response_.get()) {
- base::ListValue* details = new base::ListValue();
- strings.Set("details", details);
+ auto details = base::MakeUnique<base::ListValue>();
for (SystemLogsResponse::const_iterator it = response_->begin();
it != response_->end();
++it) {
@@ -162,6 +161,7 @@ void SystemInfoUIHTMLSource::RequestComplete() {
val->SetString("statValue", it->second);
details->Append(std::move(val));
}
+ strings.Set("details", std::move(details));
}
static const base::StringPiece systeminfo_html(
ResourceBundle::GetSharedInstance().GetRawDataResource(

Powered by Google App Engine
This is Rietveld 408576698