chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.cc - Issue 2812953002: Stop passing raw pointers to base::Value API in c/b/ui

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.cc

Issue 2812953002: Stop passing raw pointers to base::Value API in c/b/ui (Closed)

Patch Set: No ListValue::SetDouble Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/signin/sync_confirmation_handler_unittest.cc ('k') | chrome/browser/ui/webui/system_info_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.cc

diff --git a/chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.cc b/chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.cc

index 2bd61444adbb9a5a4c893beb566aba55e9d69d98..a17ed60d4ef0933e49deed4b00e84074dd8da5e1 100644

--- a/chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.cc

+++ b/chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.cc

@@ -107,7 +107,7 @@ void SyncFileSystemInternalsHandler::OnLogRecorded(

std::unique_ptr<base::ListValue> details(new base::ListValue);

details->AppendStrings(task_log.details);

- dict.Set("details", details.release());

+ dict.Set("details", std::move(details));

web_ui()->CallJavascriptFunctionUnsafe("TaskLog.onTaskLogRecorded", dict);

}

« no previous file with comments | « chrome/browser/ui/webui/signin/sync_confirmation_handler_unittest.cc ('k') | chrome/browser/ui/webui/system_info_ui.cc » ('j') | no next file with comments »