chrome/browser/ui/webui/options/search_engine_manager_handler.cc - Issue 2812953002: Stop passing raw pointers to base::Value API in c/b/ui

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/search_engine_manager_handler.cc

Issue 2812953002: Stop passing raw pointers to base::Value API in c/b/ui (Closed)

Patch Set: Rebased Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/options/search_engine_manager_handler.cc

diff --git a/chrome/browser/ui/webui/options/search_engine_manager_handler.cc b/chrome/browser/ui/webui/options/search_engine_manager_handler.cc

index e93cdd37300bd92ab778c4ec218a71585191e28e..a9d43ebca264b0459cf60d9b05ac545cb6b42c24 100644

--- a/chrome/browser/ui/webui/options/search_engine_manager_handler.cc

+++ b/chrome/browser/ui/webui/options/search_engine_manager_handler.cc

@@ -207,8 +207,7 @@ SearchEngineManagerHandler::CreateDictionaryForEngine(int index,

->GetExtensionById(template_url->GetExtensionId(),

extensions::ExtensionRegistry::EVERYTHING);

if (extension) {

- dict->Set("extension",

- extensions::util::GetExtensionInfo(extension).release());

+ dict->Set("extension", extensions::util::GetExtensionInfo(extension));

}

return dict;