chrome/browser/ui/webui/options/reset_profile_settings_handler.cc - Issue 2812953002: Stop passing raw pointers to base::Value API in c/b/ui

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/reset_profile_settings_handler.cc

Issue 2812953002: Stop passing raw pointers to base::Value API in c/b/ui (Closed)

Patch Set: Rebased Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/options/reset_profile_settings_handler.cc

diff --git a/chrome/browser/ui/webui/options/reset_profile_settings_handler.cc b/chrome/browser/ui/webui/options/reset_profile_settings_handler.cc

index 5f6f24599862ebaca664af625c6b44972d852836..bc254c3631bc538925d96c067269a67fb14ca053 100644

--- a/chrome/browser/ui/webui/options/reset_profile_settings_handler.cc

+++ b/chrome/browser/ui/webui/options/reset_profile_settings_handler.cc

@@ -261,7 +261,7 @@ void ResetProfileSettingsHandler::UpdateFeedbackUI() {

std::unique_ptr<base::ListValue> list = GetReadableFeedbackForSnapshot(

Profile::FromWebUI(web_ui()), *setting_snapshot_);

base::DictionaryValue feedback_info;

- feedback_info.Set("feedbackInfo", list.release());

+ feedback_info.Set("feedbackInfo", std::move(list));

web_ui()->CallJavascriptFunctionUnsafe(

"ResetProfileSettingsOverlay.setFeedbackInfo", feedback_info);

}