Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: chrome/browser/ui/webui/options/reset_profile_settings_handler.cc

Issue 2812953002: Stop passing raw pointers to base::Value API in c/b/ui (Closed)
Patch Set: Rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/reset_profile_settings_handler.cc
diff --git a/chrome/browser/ui/webui/options/reset_profile_settings_handler.cc b/chrome/browser/ui/webui/options/reset_profile_settings_handler.cc
index 5f6f24599862ebaca664af625c6b44972d852836..bc254c3631bc538925d96c067269a67fb14ca053 100644
--- a/chrome/browser/ui/webui/options/reset_profile_settings_handler.cc
+++ b/chrome/browser/ui/webui/options/reset_profile_settings_handler.cc
@@ -261,7 +261,7 @@ void ResetProfileSettingsHandler::UpdateFeedbackUI() {
std::unique_ptr<base::ListValue> list = GetReadableFeedbackForSnapshot(
Profile::FromWebUI(web_ui()), *setting_snapshot_);
base::DictionaryValue feedback_info;
- feedback_info.Set("feedbackInfo", list.release());
+ feedback_info.Set("feedbackInfo", std::move(list));
web_ui()->CallJavascriptFunctionUnsafe(
"ResetProfileSettingsOverlay.setFeedbackInfo", feedback_info);
}

Powered by Google App Engine
This is Rietveld 408576698