Stop passing raw pointers to base::Value API in c/b/ui

chrome/browser/ui/webui/flags_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/flags_ui.h"
 
 #include <string>

[jdoerrie, 2017/04/13 09:08:51]

#include <memory>
#include <utility>

[vabr (Chromium), 2017/04/13 12:03:14]

Done.

 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted_memory.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "build/build_config.h"
 #include "chrome/browser/about_flags.h"
 #include "chrome/browser/browser_process.h"
@@ skipping 167 matching lines @@
     return;
 
   base::DictionaryValue results;
 
   std::unique_ptr<base::ListValue> supported_features(new base::ListValue);
   std::unique_ptr<base::ListValue> unsupported_features(new base::ListValue);
   about_flags::GetFlagFeatureEntries(flags_storage_.get(),
                                      access_,
                                      supported_features.get(),
                                      unsupported_features.get());
-  results.Set(flags_ui::kSupportedFeatures, supported_features.release());
-  results.Set(flags_ui::kUnsupportedFeatures, unsupported_features.release());
+  results.Set(flags_ui::kSupportedFeatures, std::move(supported_features));
+  results.Set(flags_ui::kUnsupportedFeatures, std::move(unsupported_features));
   results.SetBoolean(flags_ui::kNeedsRestart,
                      about_flags::IsRestartNeededToCommitChanges());
   results.SetBoolean(flags_ui::kShowOwnerWarning,
                      access_ == flags_ui::kGeneralAccessFlagsOnly);
 
 #if defined(OS_WIN) || defined(OS_MACOSX) || defined(OS_CHROMEOS)
   version_info::Channel channel = chrome::GetChannel();
   results.SetBoolean(flags_ui::kShowBetaChannelPromotion,
                      channel == version_info::Channel::STABLE);
   results.SetBoolean(flags_ui::kShowDevChannelPromotion,
@@ skipping 127 matching lines @@
 
 FlagsUI::~FlagsUI() {
 }
 
 // static
 base::RefCountedMemory* FlagsUI::GetFaviconResourceBytes(
       ui::ScaleFactor scale_factor) {
   return ResourceBundle::GetSharedInstance().
       LoadDataResourceBytesForScale(IDR_FLAGS_FAVICON, scale_factor);
 }