chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.cc - Issue 2812953002: Stop passing raw pointers to base::Value API in c/b/ui

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.cc

Issue 2812953002: Stop passing raw pointers to base::Value API in c/b/ui (Closed)

Patch Set: Rebased Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/chromeos/drive_internals_ui.cc ('k') | chrome/browser/ui/webui/chromeos/login/network_dropdown.cc » ('j') | chrome/browser/ui/webui/chromeos/power_ui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.cc

diff --git a/chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.cc

index 865ceac8d9f29b416167cc64049ea7cef77968ea..a24fa3412fdb0e8486218c96392ea3b7d2da3deb 100644

--- a/chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.cc

+++ b/chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.cc

@@ -85,10 +85,9 @@ void AppLaunchSplashScreenHandler::Show(const std::string& app_id) {

data.SetBoolean("shortcutEnabled",

!KioskAppManager::Get()->GetDisableBailoutShortcut());

- // |data| will take ownership of |app_info|.

- base::DictionaryValue *app_info = new base::DictionaryValue();

- PopulateAppInfo(app_info);

- data.Set("appInfo", app_info);

+ auto app_info = base::MakeUnique<base::DictionaryValue>();

+ PopulateAppInfo(app_info.get());

+ data.Set("appInfo", std::move(app_info));

SetLaunchText(l10n_util::GetStringUTF8(GetProgressMessageFromState(state_)));

ShowScreenWithData(kScreenId, &data);