Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2812823004: Revert of Separate CSSValueID mappings generator from ComputedStyleBase generator. (Closed)

Created:
3 years, 8 months ago by jdoerrie
Modified:
3 years, 8 months ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Separate CSSValueID mappings generator from ComputedStyleBase generator. (patchset #3 id:40001 of https://codereview.chromium.org/2794853002/ ) Reason for revert: Broke compilation on Google Chrome Mac bot BUG=710778 Original issue's description: > Separate CSSValueID mappings generator from ComputedStyleBase generator. > > We currently generate mappings between CSSValueID and platform enums > inside the ComputedStyleBase generator. However, because such mappings > do not exist for nonproperty fields, it no longer makes sense for us > to generate these mappings inside make_computed_style_base.py. > > This patch moves the generator for CSSValueIDMappingsGenerated to > its own file, so that it is not affected by nonproperty fields. > > BUG=628043 > > Review-Url: https://codereview.chromium.org/2794853002 > Cr-Commit-Position: refs/heads/master@{#463955} > Committed: https://chromium.googlesource.com/chromium/src/+/dea75f9603af994dd10370ddd25a0dc6af7b93cd TBR=bugsnash@chromium.org,meade@chromium.org,shend@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=628043 Review-Url: https://codereview.chromium.org/2812823004 Cr-Commit-Position: refs/heads/master@{#463966} Committed: https://chromium.googlesource.com/chromium/src/+/2b7de53bdbe24c3d8088d23862abdd35de67f711

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -51 lines) Patch
M third_party/WebKit/Source/build/scripts/make_computed_style_base.py View 2 chunks +17 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/build/scripts/make_css_value_id_mappings.py View 1 chunk +0 lines, -43 lines 0 comments Download
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jdoerrie
Created Revert of Separate CSSValueID mappings generator from ComputedStyleBase generator.
3 years, 8 months ago (2017-04-12 08:39:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812823004/1
3 years, 8 months ago (2017-04-12 08:39:52 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 08:41:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2b7de53bdbe24c3d8088d23862ab...

Powered by Google App Engine
This is Rietveld 408576698