Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2812803002: WebUI: change up some owners (Closed)

Created:
3 years, 8 months ago by Dan Beam
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WebUI: change up some owners 1. Remove estade@ from main OWNERS file 👋 So long and thanks for all the fish! 🐟🐠 2. Create a "PLATFORM_OWNERS" file so that fukino@ can be added for only ui/webui/ (and not all the other things covered). 3. Add calamity@ to new PLATFORM_OWNERS file. 4. Add groby@ to content/browser/webui/ for her super contributions. 5. Add dschuyler@ to ui/base/webui/ for his sweet $i18n{} stuff. R=estade@chromium.org,fukino@chromium.org,calamity@chromium.org BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2812803002 Cr-Commit-Position: refs/heads/master@{#465902} Committed: https://chromium.googlesource.com/chromium/src/+/af7339ee1c228d233c7639530b238657df4ce6ac

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -28 lines) Patch
M chrome/browser/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/uber/OWNERS View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
M components/about_ui/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
M components/flags_ui/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
M components/version_ui/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webui/OWNERS View 1 1 chunk +1 line, -3 lines 0 comments Download
M ui/base/webui/OWNERS View 1 1 chunk +3 lines, -2 lines 0 comments Download
M ui/webui/OWNERS View 1 1 chunk +2 lines, -10 lines 0 comments Download
A + ui/webui/PLATFORM_OWNERS View 1 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 34 (20 generated)
Dan Beam
3 years, 8 months ago (2017-04-11 01:18:39 UTC) #3
Evan Stade
lgtm and ok to remove from everything except ntp4
3 years, 8 months ago (2017-04-11 20:36:03 UTC) #4
Dan Beam
made this a little bigger because there's been a few owners changes required lately everybody ...
3 years, 8 months ago (2017-04-18 18:45:12 UTC) #12
Dan Beam
also, fwiw, totally open to a different name than "PLATFORM_OWNERS", just the best i could ...
3 years, 8 months ago (2017-04-18 18:50:30 UTC) #13
dschuyler
lgtm
3 years, 8 months ago (2017-04-18 18:52:13 UTC) #14
calamity
lgtm
3 years, 8 months ago (2017-04-19 01:42:19 UTC) #15
groby-ooo-7-16
On 2017/04/19 01:42:19, calamity wrote: > lgtm I feel like IT'S A TRAP, but... lgtm
3 years, 8 months ago (2017-04-19 17:13:58 UTC) #16
fukino
lgtm. Thank you!
3 years, 8 months ago (2017-04-20 00:24:44 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812803002/20001
3 years, 8 months ago (2017-04-20 00:46:39 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/415908)
3 years, 8 months ago (2017-04-20 00:57:36 UTC) #26
Dan Beam
+thestig@ for file rename in chrome/browser/OWNERS
3 years, 8 months ago (2017-04-20 02:27:27 UTC) #28
Lei Zhang
lgtm
3 years, 8 months ago (2017-04-20 03:59:23 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812803002/20001
3 years, 8 months ago (2017-04-20 05:12:25 UTC) #31
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 05:19:04 UTC) #34
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/af7339ee1c228d233c7639530b23...

Powered by Google App Engine
This is Rietveld 408576698