Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2812793002: Omnibox - Allow On-Focus Suggestions on Android Incognito (Closed)

Created:
3 years, 8 months ago by Mark P
Modified:
3 years, 8 months ago
Reviewers:
Maria
CC:
chromium-reviews, jdonnelly+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Omnibox - Allow On-Focus Suggestions on Android Incognito Instead of a blanket prohibition, each provider can make its own decisions about when to trigger and when not to. Currently I believe the only provider that will sometimes trigger is clipboard URL provider. BUG=708774 Review-Url: https://codereview.chromium.org/2812793002 Cr-Commit-Position: refs/heads/master@{#463528} Committed: https://chromium.googlesource.com/chromium/src/+/6eaf7fc310350fba0b59738040d6f97b640d553e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java View 1 chunk +1 line, -2 lines 0 comments Download
M components/omnibox/browser/zero_suggest_provider.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
Mark P
Wow, this really was as easy as I hoped. Please take a look Maria. thanks, ...
3 years, 8 months ago (2017-04-10 23:00:37 UTC) #3
Maria
lgtm
3 years, 8 months ago (2017-04-10 23:08:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812793002/1
3 years, 8 months ago (2017-04-11 04:04:25 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 04:11:33 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6eaf7fc310350fba0b59738040d6...

Powered by Google App Engine
This is Rietveld 408576698