Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2812783002: Always post mailbox release in GpuVideoDecoder; avoids deadlock. (Closed)

Created:
3 years, 8 months ago by DaleCurtis
Modified:
3 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Always post mailbox release in GpuVideoDecoder; avoids deadlock. We can get into a situation where GVD::ReleaseMailbox() attempts to grab the GL context lock while the compositor holds it wheil waiting on a lock in VideoRendererImpl which may also be held during a call to GVD::ReleaseMailbox(). Not sure how to test this since we have no test harness capable of instantiating all these components at the same time and some live across content/ and media/ boundaries. BUG=710209 TEST=none Review-Url: https://codereview.chromium.org/2812783002 Cr-Commit-Position: refs/heads/master@{#463857} Committed: https://chromium.googlesource.com/chromium/src/+/0a9f673ccd4f82b350c06df622f323b255ebab21

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -19 lines) Patch
M media/filters/gpu_video_decoder.cc View 2 chunks +5 lines, -19 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
DaleCurtis
3 years, 8 months ago (2017-04-10 22:53:30 UTC) #2
sandersd (OOO until July 31)
lgtm
3 years, 8 months ago (2017-04-11 22:27:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812783002/1
3 years, 8 months ago (2017-04-11 22:39:33 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 00:37:14 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0a9f673ccd4f82b350c06df622f3...

Powered by Google App Engine
This is Rietveld 408576698