Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2812743003: Rename cleanup in comments in css/ directory. (Closed)

Created:
3 years, 8 months ago by rune
Modified:
3 years, 8 months ago
Reviewers:
meade_UTC10, dcheng
CC:
chromium-reviews, kenneth.christiansen, Yoav Weiss, dtapuska+blinkwatch_chromium.org, blink-reviews-style_chromium.org, blink-reviews-css, eae+blinkwatch, blink-reviews-events_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename cleanup in comments in css/ directory. After the renaming of methods and variables to match chromium style, a bunch of comments were not correct. BUG=643310 Review-Url: https://codereview.chromium.org/2812743003 Cr-Commit-Position: refs/heads/master@{#463561} Committed: https://chromium.googlesource.com/chromium/src/+/3745cb5bd5243023ef22518dad02383a2f0de67e

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -97 lines) Patch
M third_party/WebKit/Source/core/css/CSSFontFaceSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSFontFaceSrcValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSFontSelector.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSImageSetValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSSegmentedFontFace.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSSelector.h View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSSelector.cpp View 2 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSSelectorList.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSSelectorList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSToLengthConversionData.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSValueKeywords.json5 View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFaceSet.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryListEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/MediaValues.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleSet.cpp View 1 chunk +3 lines, -3 lines 1 comment Download
M third_party/WebKit/Source/core/css/SelectorChecker.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/StylePropertySerializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/StylePropertySet.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/StyleRule.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/StyleSheetContents.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSLengthValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSUnitValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp View 3 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/invalidation/InvalidationSet.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSLazyParsingState.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserToken.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSTokenizer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ElementStyleResources.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/FontBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/FontBuilderTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/MatchedPropertiesCache.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolverState.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolverState.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
rune
Is this premature? If not, ptal.
3 years, 8 months ago (2017-04-10 22:40:11 UTC) #4
dcheng
LGTM. Thanks for cleaning these up (it's on the TODO list; perhaps we can tag ...
3 years, 8 months ago (2017-04-10 23:19:57 UTC) #5
meade_UTC10
lgtm \o/ Did you use a script to find these by any chance? Would be ...
3 years, 8 months ago (2017-04-10 23:59:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812743003/1
3 years, 8 months ago (2017-04-11 07:04:08 UTC) #11
rune
On 2017/04/10 23:59:43, Eddy_UTC10 wrote: > lgtm > > \o/ Did you use a script ...
3 years, 8 months ago (2017-04-11 07:05:05 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 07:23:08 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3745cb5bd5243023ef22518dad02...

Powered by Google App Engine
This is Rietveld 408576698