Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Issue 2812713002: [DevTools] Make dock buttons from main menu work on click (Closed)

Created:
3 years, 8 months ago by dgozman
Modified:
3 years, 8 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Make dock buttons from main menu work on click This was regressed in crrev.com/9d09b0aeddb1407f22981575e6b4fd8473830c5d. BUG=709855 Review-Url: https://codereview.chromium.org/2812713002 Cr-Commit-Position: refs/heads/master@{#463422} Committed: https://chromium.googlesource.com/chromium/src/+/305068050c006f0d1e46f3c9d5df74f7519cf3a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
dgozman
Could you please take a look?
3 years, 8 months ago (2017-04-10 20:44:11 UTC) #2
lushnikov
lgtm
3 years, 8 months ago (2017-04-10 21:25:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812713002/1
3 years, 8 months ago (2017-04-10 22:27:01 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 22:37:35 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/305068050c006f0d1e46f3c9d5df...

Powered by Google App Engine
This is Rietveld 408576698