Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2812703003: aw: Remove global AllowWait on UI thread (Closed)

Created:
3 years, 8 months ago by boliu
Modified:
3 years, 8 months ago
Reviewers:
jam, Torne
CC:
chromium-reviews, jam, danakj+watch_chromium.org, darin-cc_chromium.org, android-webview-reviews_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

aw: Remove global AllowWait on UI thread Two specific cases left for webview. SynchronousCompositor needs to send synchronous IPC messages, in order to maintain synchronous behavior for backward compatibility without merging the UI thread with the renderer compositor thread. There is a design doc for this in crbug.com/526842#c10 CookieManager, has has to run before a UI thread in webview has been determined. So CookieManager starts on its own thread, and any thread, including the UI thread, can wait for a result synchronously based on the cookie manager thread. BUG=240453 Review-Url: https://codereview.chromium.org/2812703003 Cr-Commit-Position: refs/heads/master@{#463849} Committed: https://chromium.googlesource.com/chromium/src/+/2ce547e8ae0c6a41876f95aec2465a0d1031ae52

Patch Set 1 #

Patch Set 2 : future #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -67 lines) Patch
M android_webview/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/browser/find_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/browser/renderer_host/aw_render_view_host_ext.cc View 1 chunk +0 lines, -1 line 0 comments Download
D android_webview/browser/scoped_allow_wait_for_legacy_web_view_api.h View 1 chunk +0 lines, -20 lines 0 comments Download
M android_webview/lib/main/aw_main_delegate.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M android_webview/native/cookie_manager.cc View 6 chunks +7 lines, -6 lines 0 comments Download
M base/threading/thread_restrictions.h View 1 3 chunks +11 lines, -2 lines 0 comments Download
M content/browser/android/synchronous_compositor_browser_filter.cc View 1 chunk +8 lines, -5 lines 0 comments Download
M content/browser/android/synchronous_compositor_host.cc View 6 chunks +35 lines, -19 lines 0 comments Download
M content/public/browser/android/synchronous_compositor.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
boliu
ptal SynchronousCompositor waits are spread across three classes which kinda sucks, but somewhat unavoidable.
3 years, 8 months ago (2017-04-11 15:10:27 UTC) #8
Torne
LGTM, both in general and the android_webview and CookieManager bits specifically :)
3 years, 8 months ago (2017-04-11 20:36:03 UTC) #9
jam
lgtm
3 years, 8 months ago (2017-04-11 23:25:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812703003/20001
3 years, 8 months ago (2017-04-11 23:27:45 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 00:09:10 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2ce547e8ae0c6a41876f95aec246...

Powered by Google App Engine
This is Rietveld 408576698