Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2812653002: Revert of Ensure counters are initialized, to avoid init on non-joinable threads. (Closed)

Created:
3 years, 8 months ago by jgruber
Modified:
3 years, 8 months ago
CC:
ahaas, bradnelson, kschimpf, v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Ensure counters are initialized, to avoid init on non-joinable threads. (patchset #1 id:1 of https://codereview.chromium.org/2812543002/ ) Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20gyp/builds/5221 Original issue's description: > Ensure counters are initialized, to avoid init on non-joinable threads. > > This occurs in the wasm scenario described in the referenced bug. > DecodeWasmModule collects statistics. Blink inserts a CreateHistogramCallback that > can't instantiate a histogram on non-joinable threads. Turns out, DecodeWasmModule > is scheduled on such a thread, now that we have async compilation. > > This fix pre-initializes histograms when the callback is applied, which is assumed to > be in a context that can carry out the instantiation. In Blink, this happens on the main > thread. > > BUG=chromium:709684 > > Review-Url: https://codereview.chromium.org/2812543002 > Cr-Commit-Position: refs/heads/master@{#44522} > Committed: https://chromium.googlesource.com/v8/v8/+/022e7ddf232b0696eb595769fa702463c417db5e TBR=jochen@chromium.org,mtrofin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:709684 Review-Url: https://codereview.chromium.org/2812653002 Cr-Commit-Position: refs/heads/master@{#44527} Committed: https://chromium.googlesource.com/v8/v8/+/038bafcb8c0435bc4130228237124331295d4713

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -27 lines) Patch
M src/api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/counters.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/counters.cc View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
jgruber
Created Revert of Ensure counters are initialized, to avoid init on non-joinable threads.
3 years, 8 months ago (2017-04-10 14:56:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812653002/1
3 years, 8 months ago (2017-04-10 14:56:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/038bafcb8c0435bc4130228237124331295d4713
3 years, 8 months ago (2017-04-10 14:56:55 UTC) #6
Mircea Trofin
3 years, 8 months ago (2017-04-10 15:15:31 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2813673002/ by mtrofin@chromium.org.

The reason for reverting is: Appears to be a flake. Both jgruber and I tried to
repro locally and failed. Also change has little change of having had caused
those failures..

Powered by Google App Engine
This is Rietveld 408576698