Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2812643003: Revert of add a new set of commands to resize and position windows (Closed)

Created:
3 years, 8 months ago by jzfeng
Modified:
3 years, 8 months ago
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, darin-cc_chromium.org, devtools-reviews_chromium.org, jam, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman, pfeldman+blink_chromium.org, samuong
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of add a new set of commands to resize and position windows (patchset #35 id:680001 of https://codereview.chromium.org/2734123004/ ) Reason for revert: It cause flaky browser tests on mac10.10 https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests?numbuilds=100 Original issue's description: > add a new set of commands to resize and position windows > > https://docs.google.com/document/d/1Q0kuHgU1d-sj8gePjEU9nHtlQzz5rNvvGH8fCJ3iBq4/edit?usp=sharing > > Devtools side, add a new UI domain and methods: > method: getWindowForTarget, param: targetID, return: windowID, bounds. > method: setWindowBounds, param: windowID, bounds > method: getWindowBounds, param: windowID, return: bounds > > bounds object: left, top, width, height, window_state (minimized, maximized, fullscreen, normal) > > BUG=604324 > > Review-Url: https://codereview.chromium.org/2734123004 > Cr-Commit-Position: refs/heads/master@{#463110} > Committed: https://chromium.googlesource.com/chromium/src/+/24a8ad434aab59c8c8a08ba02d934ca5fdfdc7dd TBR=dgozman@chromium.org,pfeldman@chromium.org,samuong@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=604324

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -524 lines) Patch
M chrome/browser/devtools/chrome_devtools_manager_delegate.h View 3 chunks +0 lines, -16 lines 0 comments Download
M chrome/browser/devtools/chrome_devtools_manager_delegate.cc View 6 chunks +4 lines, -226 lines 0 comments Download
M chrome/browser/devtools/devtools_protocol.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/devtools/devtools_protocol.cc View 2 chunks +3 lines, -15 lines 0 comments Download
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 4 chunks +0 lines, -201 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/schema-get-domains-matches-agents-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/browser_protocol.json View 2 chunks +1 line, -61 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
jzfeng
Created Revert of add a new set of commands to resize and position windows
3 years, 8 months ago (2017-04-10 17:07:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812643003/1
3 years, 8 months ago (2017-04-10 17:08:13 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-10 17:08:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812643003/1
3 years, 8 months ago (2017-04-10 17:12:05 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-10 17:12:08 UTC) #9
hongchan
lgtm
3 years, 8 months ago (2017-04-10 17:12:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812643003/1
3 years, 8 months ago (2017-04-10 17:13:25 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 17:17:00 UTC) #14
Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

Powered by Google App Engine
This is Rietveld 408576698