Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2812623003:
Reenable two interactive ui tests (Closed)
|
Created:
3 years, 8 months ago by weidongg Modified:
3 years, 8 months ago Reviewers:
Peter Kasting CC:
chromium-reviews, tfarina, dcheng, afakhry, oshima Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionReenable two interactive ui tests
The behavior of PressSecondFingerWhileDetached test has changed. The drag is complete successfully instead of being reverted after second finger press.
Both CancelDragTabToWindowIn1stDisplay and PressSecondFingerWhileDetached tests have certain odds to be timeout if they are running locally. But it runs well on try bot.
modified: chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
BUG=626763
Review-Url: https://codereview.chromium.org/2812623003
Cr-Commit-Position: refs/heads/master@{#463672}
Committed: https://chromium.googlesource.com/chromium/src/+/23910e967cb775dbc38dee6b0f06c3c69d93be1e
Patch Set 1 #Patch Set 2 : Modify the PressSecondFingerWhileDetached test #
Total comments: 6
Patch Set 3 : Applied fix #Messages
Total messages: 19 (14 generated)
The CQ bit was checked by weidongg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by weidongg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Reenable several interactive ui test All the interactive ui tests using 'ash-host-window-bound' to create windows have certain odds to be timeout if they are running locally. But it runs well on try bot. modified: chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc BUG=626763 ========== to ========== Reenable two interactive ui tests The behavior of PressSecondFingerWhileDetached test has changed. The drag is complete successfully instead of being reverted after second finger press. Both CancelDragTabToWindowIn1stDisplay and PressSecondFingerWhileDetached tests have certain odds to be timeout if they are running locally. But it runs well on try bot. modified: chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc BUG=626763 ==========
weidongg@chromium.org changed reviewers: + pkasting@chromium.org
LGTM https://codereview.chromium.org/2812623003/diff/20001/chrome/browser/ui/views... File chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc (left): https://codereview.chromium.org/2812623003/diff/20001/chrome/browser/ui/views... chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc:2434: ASSERT_TRUE(DragInputToDelayedNotifyWhenDone( If you're removing this call, remove the whole function https://codereview.chromium.org/2812623003/diff/20001/chrome/browser/ui/views... File chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc (right): https://codereview.chromium.org/2812623003/diff/20001/chrome/browser/ui/views... chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc:2413: Browser* new_browser = test->browser_list->get(1); Nit: Can just inline into next line (2 places) https://codereview.chromium.org/2812623003/diff/20001/chrome/browser/ui/views... chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc:2429: // Continue dragging after adding a second finger. Nit: Put comment above line above
https://codereview.chromium.org/2812623003/diff/20001/chrome/browser/ui/views... File chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc (left): https://codereview.chromium.org/2812623003/diff/20001/chrome/browser/ui/views... chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc:2434: ASSERT_TRUE(DragInputToDelayedNotifyWhenDone( On 2017/04/11 02:15:24, Peter Kasting wrote: > If you're removing this call, remove the whole function Done. https://codereview.chromium.org/2812623003/diff/20001/chrome/browser/ui/views... File chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc (right): https://codereview.chromium.org/2812623003/diff/20001/chrome/browser/ui/views... chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc:2413: Browser* new_browser = test->browser_list->get(1); On 2017/04/11 02:15:24, Peter Kasting wrote: > Nit: Can just inline into next line (2 places) Done. https://codereview.chromium.org/2812623003/diff/20001/chrome/browser/ui/views... chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc:2429: // Continue dragging after adding a second finger. On 2017/04/11 02:15:24, Peter Kasting wrote: > Nit: Put comment above line above Done.
The CQ bit was checked by weidongg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pkasting@chromium.org Link to the patchset: https://codereview.chromium.org/2812623003/#ps40001 (title: "Applied fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491929395993010,
"parent_rev": "28d8b7398617c37736dd2e04afd656795e6cac28", "commit_rev":
"23910e967cb775dbc38dee6b0f06c3c69d93be1e"}
Message was sent while issue was closed.
Description was changed from ========== Reenable two interactive ui tests The behavior of PressSecondFingerWhileDetached test has changed. The drag is complete successfully instead of being reverted after second finger press. Both CancelDragTabToWindowIn1stDisplay and PressSecondFingerWhileDetached tests have certain odds to be timeout if they are running locally. But it runs well on try bot. modified: chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc BUG=626763 ========== to ========== Reenable two interactive ui tests The behavior of PressSecondFingerWhileDetached test has changed. The drag is complete successfully instead of being reverted after second finger press. Both CancelDragTabToWindowIn1stDisplay and PressSecondFingerWhileDetached tests have certain odds to be timeout if they are running locally. But it runs well on try bot. modified: chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc BUG=626763 Review-Url: https://codereview.chromium.org/2812623003 Cr-Commit-Position: refs/heads/master@{#463672} Committed: https://chromium.googlesource.com/chromium/src/+/23910e967cb775dbc38dee6b0f06... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/23910e967cb775dbc38dee6b0f06... |
