Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 2812613002: [api] Expose instanceof through v8::Value::InstanceOf. (Closed)

Created:
3 years, 8 months ago by Yang
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Expose instanceof through v8::Value::InstanceOf. This is requested for Node.js N-API. Tests to be added. Review-Url: https://codereview.chromium.org/2812613002 Cr-Commit-Position: refs/heads/master@{#44641} Committed: https://chromium.googlesource.com/v8/v8/+/768c5e2143830f4538765b24381908670028c32d

Patch Set 1 #

Patch Set 2 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -1 line) Patch
M include/v8.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/api.cc View 1 2 chunks +12 lines, -1 line 0 comments Download
M src/counters.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +57 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Yang
Please take a look. Will land after branch cut.
3 years, 8 months ago (2017-04-11 12:04:03 UTC) #3
jochen (gone - plz use gerrit)
lgtm
3 years, 8 months ago (2017-04-11 12:06:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812613002/20001
3 years, 8 months ago (2017-04-13 12:35:45 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 12:37:29 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/768c5e2143830f4538765b2438190867002...

Powered by Google App Engine
This is Rietveld 408576698