Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2812603002: [api] consistently expose all well-known symbols. (Closed)

Created:
3 years, 8 months ago by Yang
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[api] consistently expose all well-known symbols. R=jochen@chromium.org Review-Url: https://codereview.chromium.org/2812603002 Cr-Commit-Position: refs/heads/master@{#44643} Committed: https://chromium.googlesource.com/v8/v8/+/c80c0f11f4c14d7ede75b79efccab1d4d1fc86ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -30 lines) Patch
M include/v8.h View 1 chunk +7 lines, -2 lines 0 comments Download
M src/api.cc View 1 chunk +22 lines, -28 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Yang
3 years, 8 months ago (2017-04-10 12:19:10 UTC) #1
Yang
Please take a look. This has been brought up here: https://github.com/nodejs/node/pull/12246#issuecomment-292572373 I won't land before ...
3 years, 8 months ago (2017-04-10 12:19:36 UTC) #2
jochen (gone - plz use gerrit)
lgtm
3 years, 8 months ago (2017-04-10 12:51:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812603002/1
3 years, 8 months ago (2017-04-13 12:38:45 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 12:40:47 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/c80c0f11f4c14d7ede75b79efccab1d4d1f...

Powered by Google App Engine
This is Rietveld 408576698