Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2812593005: Rename cleanup in comments in style/ directory. (Closed)

Created:
3 years, 8 months ago by rune
Modified:
3 years, 8 months ago
Reviewers:
meade_UTC10, dcheng
CC:
chromium-reviews, blink-reviews, blink-reviews-style_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename cleanup in comments in style/ directory. After the renaming of methods and variables to match chromium style, a bunch of comments were not correct. BUG=643310 Review-Url: https://codereview.chromium.org/2812593005 Cr-Commit-Position: refs/heads/master@{#463559} Committed: https://chromium.googlesource.com/chromium/src/+/09853278f973fdfafbfffdd695cff8d7e4cc3aeb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M third_party/WebKit/Source/core/style/BasicShapes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/CachedUAStyle.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/style/FilterOperation.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/FilterOperations.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/GridArea.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareNonInheritedData.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
rune
Is this premature? If not, ptal.
3 years, 8 months ago (2017-04-10 22:40:42 UTC) #3
rune
3 years, 8 months ago (2017-04-10 22:41:07 UTC) #5
dcheng
LGTM
3 years, 8 months ago (2017-04-10 23:18:00 UTC) #6
dcheng
Also, add BUG=643310
3 years, 8 months ago (2017-04-10 23:20:03 UTC) #7
meade_UTC10
lgtm
3 years, 8 months ago (2017-04-11 05:02:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812593005/1
3 years, 8 months ago (2017-04-11 07:06:33 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 07:19:10 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/09853278f973fdfafbfffdd695cf...

Powered by Google App Engine
This is Rietveld 408576698