third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp - Issue 2812593003: Remove caching of contents paint properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp

Issue 2812593003: Remove caching of contents paint properties (Closed)

Patch Set: Address reviewer comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp

diff --git a/third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp b/third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp

index e98f8255034cebe1f1fc902323ac59e80c95ca2a..398740046333a759ee862b6c89d146f580adaa3a 100644

--- a/third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp

+++ b/third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp

@@ -45,7 +45,7 @@ class VisualRectMappingTest : public RenderingTest {

if (object.PaintProperties() || object.LocalBorderBoxProperties()) {

geometry_mapper_rect.MoveBy(FloatPoint(object.PaintOffset()));

GeometryMapper::SourceToDestinationVisualRect(

- *object.LocalBorderBoxProperties(), *ancestor.ContentsProperties(),

+ *object.LocalBorderBoxProperties(), ancestor.ContentsProperties(),

geometry_mapper_rect);

geometry_mapper_rect.MoveBy(-FloatPoint(ancestor.PaintOffset()));

}