Initialize ICU before fuzzing the template URL parser.

Initialize ICU before fuzzing the template URL parser.

BUG=709449
Review-Url: https://codereview.chromium.org/2812503002
Cr-Commit-Position: refs/heads/master@{#463243}
Committed: https://chromium.googlesource.com/chromium/src/+/4feb2b85c555d8279df7477b7f418aa0a1556790

[dominicc (has gone to gerrit), 2017-04-10 05:37:04]

The CQ bit was checked by dominicc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 05:37:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominicc (has gone to gerrit), 2017-04-10 05:38:50]

dominicc@chromium.org changed reviewers:
+ mmoroz@chromium.org

[dominicc (has gone to gerrit), 2017-04-10 05:38:50]

PTAL

[commit-bot: I haz the power, 2017-04-10 07:03:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 07:03:13]

Dry run: This issue passed the CQ dry run.

[inferno, 2017-04-10 13:30:48]

inferno@chromium.org changed reviewers:
+ inferno@chromium.org

[inferno, 2017-04-10 13:30:49]

The CQ bit was checked by inferno@chromium.org

[inferno, 2017-04-10 13:30:49]

lgtm

[commit-bot: I haz the power, 2017-04-10 13:31:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 13:34:47]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491831049076470, "parent_rev":
"eb23c96cd70370efc27bd8995e079c3ead3a214c", "commit_rev":
"4feb2b85c555d8279df7477b7f418aa0a1556790"}

[commit-bot: I haz the power, 2017-04-10 13:35:37]

Description was changed from

==========
Initialize ICU before fuzzing the template URL parser.

BUG=709449
==========

to

==========
Initialize ICU before fuzzing the template URL parser.

BUG=709449

Review-Url: https://codereview.chromium.org/2812503002
Cr-Commit-Position: refs/heads/master@{#463243}
Committed:
https://chromium.googlesource.com/chromium/src/+/4feb2b85c555d8279df7477b7f41...
==========

[commit-bot: I haz the power, 2017-04-10 13:35:38]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4feb2b85c555d8279df7477b7f41...

[jochen (gone - plz use gerrit), 2017-04-18 07:08:56]

jochen@chromium.org changed reviewers:
+ jochen@chromium.org

[jochen (gone - plz use gerrit), 2017-04-18 07:08:57]

https://codereview.chromium.org/2812503002/diff/1/testing/libfuzzer/fuzzers/t...
File testing/libfuzzer/fuzzers/template_url_parser_fuzzer.cc (right):

https://codereview.chromium.org/2812503002/diff/1/testing/libfuzzer/fuzzers/t...
testing/libfuzzer/fuzzers/template_url_parser_fuzzer.cc:40:
base::i18n::InitializeICU();
for posterity, we can't initialize ICU once per fuzzer run, instead, we should
add a function extern "C" int LLVMFuzzerInitialize(int* argc, char*** argv) that
initializes ICU

[kcc2, 2017-04-18 16:07:51]

On 2017/04/18 07:08:57, jochen wrote:
>
https://codereview.chromium.org/2812503002/diff/1/testing/libfuzzer/fuzzers/t...
> File testing/libfuzzer/fuzzers/template_url_parser_fuzzer.cc (right):
> 
>
https://codereview.chromium.org/2812503002/diff/1/testing/libfuzzer/fuzzers/t...
> testing/libfuzzer/fuzzers/template_url_parser_fuzzer.cc:40:
> base::i18n::InitializeICU();
> for posterity, we can't initialize ICU once per fuzzer run, instead, we should
> add a function extern "C" int LLVMFuzzerInitialize(int* argc, char*** argv)
that
> initializes ICU

you may also use 
static int Initialized = InitializeMe() inside the fuzz target
(LLVMFuzzerTestOneInput).
In fact, I typically recommend this way over LLVMFuzzerInitialize
(use LLVMFuzzerInitialize only when you need to capture argv)