Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2812403003: Set public_deps for //components/google/core/browser. (Closed)

Created:
3 years, 8 months ago by mattm
Modified:
3 years, 8 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Set public_deps for //components/google/core/browser. Header files in components/google/core/browser include files from these targets, therefore they should be public_deps. Example error: In file included from ../../chrome/browser/rlz/chrome_rlz_tracker_delegate.cc:24: In file included from ../../components/search_engines/template_url_service.h:23: In file included from ../../components/google/core/browser/google_url_tracker.h:17: In file included from ../../net/url_request/url_fetcher.h:19: In file included from ../../net/url_request/url_request.h:26: In file included from ../../net/base/net_error_details.h:9: In file included from ../../net/http/http_response_info.h:14: In file included from ../../net/ssl/ssl_info.h:20: In file included from ../../net/ssl/ssl_config.h:12: In file included from ../../net/cert/x509_certificate.h:25: ../../third_party/boringssl/src/include/openssl/base.h:68:10: fatal error: 'openssl/opensslconf.h' file not found BUG=none Review-Url: https://codereview.chromium.org/2812403003 Cr-Commit-Position: refs/heads/master@{#464302} Committed: https://chromium.googlesource.com/chromium/src/+/888cf7c28286229cb62da42125ee41302d32b2de

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M components/google/core/browser/BUILD.gn View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
mattm
3 years, 8 months ago (2017-04-13 01:49:54 UTC) #2
Peter Kasting
LGTM
3 years, 8 months ago (2017-04-13 03:54:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812403003/1
3 years, 8 months ago (2017-04-13 04:29:26 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 04:59:13 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/888cf7c28286229cb62da42125ee...

Powered by Google App Engine
This is Rietveld 408576698