Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2812373004: [Sensors] Add README.md files (Closed)

Created:
3 years, 8 months ago by Mikhail
Modified:
3 years, 8 months ago
CC:
chromium-reviews, haraken, blink-reviews, wanming.lin, shalamov, Mikhail
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sensors] Add README.md files Add README.md files to the Generic Sensor implementation directories. NOTRY=true BUG=606766 Review-Url: https://codereview.chromium.org/2812373004 Cr-Commit-Position: refs/heads/master@{#465191} Committed: https://chromium.googlesource.com/chromium/src/+/73d510e13f60369fd425d212ccf996c56bfc402b

Patch Set 1 #

Total comments: 1

Patch Set 2 : wrapped #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -0 lines) Patch
A device/generic_sensor/README.md View 1 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/sensor/README.md View 1 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
shalamov
lgtm
3 years, 8 months ago (2017-04-13 09:37:18 UTC) #2
Mikhail
Reilly, could you PTAL?
3 years, 8 months ago (2017-04-13 09:45:35 UTC) #5
Reilly Grant (use Gerrit)
Please wrap to 80 columns. lgtm https://codereview.chromium.org/2812373004/diff/1/third_party/WebKit/Source/modules/sensor/README.md File third_party/WebKit/Source/modules/sensor/README.md (right): https://codereview.chromium.org/2812373004/diff/1/third_party/WebKit/Source/modules/sensor/README.md#newcode17 third_party/WebKit/Source/modules/sensor/README.md:17: Sensors layout tests ...
3 years, 8 months ago (2017-04-13 14:40:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812373004/20001
3 years, 8 months ago (2017-04-18 09:44:49 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 09:48:16 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/73d510e13f60369fd425d212ccf9...

Powered by Google App Engine
This is Rietveld 408576698