Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2812293002:
Flush TaskScheduler in ~ScopedTaskEnvironment and ~ScopedAsyncTaskScheduler. (Closed)
DescriptionFlush TaskScheduler in ~ScopedTaskEnvironment and ~ScopedAsyncTaskScheduler.
Skipping tasks when destroying ScopedTaskEnvironment or
ScopedAsyncTaskScheduler means that DeleteSoon() tasks
can be skipped, resulting in memory leaks.
BUG=708584, 709095
Review-Url: https://codereview.chromium.org/2812293002
Cr-Commit-Position: refs/heads/master@{#464380}
Committed: https://chromium.googlesource.com/chromium/src/+/6044a51d3e0eff211412224d21f62777db7641a4
Patch Set 1 #
Total comments: 2
Patch Set 2 : CR-gab-8-add-comment #
Messages
Total messages: 22 (16 generated)
Description was changed from ========== Flush TaskScheduler in ~ScopedTaskEnvironment and ~ScopedAsyncTaskScheduler. BUG=708584, 709095 ========== to ========== Flush TaskScheduler in ~ScopedTaskEnvironment and ~ScopedAsyncTaskScheduler. Skipping tasks when destroying ScopedTaskEnvironment or ScopedAsyncTaskScheduler means that DeleteSoon() tasks can be skipped, resulting in memory leaks. BUG=708584, 709095 ==========
fdoray@chromium.org changed reviewers: + gab@chromium.org
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
PTAL
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm w/ comment https://codereview.chromium.org/2812293002/diff/1/base/test/scoped_task_envir... File base/test/scoped_task_environment.cc (right): https://codereview.chromium.org/2812293002/diff/1/base/test/scoped_task_envir... base/test/scoped_task_environment.cc:35: TaskScheduler::GetInstance()->FlushForTesting(); Add a comment explaining why it's required.
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
The CQ bit was unchecked by fdoray@chromium.org
The CQ bit was checked by fdoray@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org Link to the patchset: https://codereview.chromium.org/2812293002/#ps20001 (title: "CR-gab-8-add-comment")
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2812293002/diff/1/base/test/scoped_task_envir... File base/test/scoped_task_environment.cc (right): https://codereview.chromium.org/2812293002/diff/1/base/test/scoped_task_envir... base/test/scoped_task_environment.cc:35: TaskScheduler::GetInstance()->FlushForTesting(); On 2017/04/12 19:18:34, gab wrote: > Add a comment explaining why it's required. Done.
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492025733431180,
"parent_rev": "ceee946b0e7737fb3e3b0b81ae6c6b7e80f3b86e", "commit_rev":
"29eaa4e97618953e28c79a88ed2742cc2d870bb6"}
The CQ bit was unchecked by commit-bot@chromium.org
Prior attempt to commit was detected, but we were not able to check whether the issue was successfully committed. Please check Git history manually and re-check CQ or close this issue as needed.
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492084850341830,
"parent_rev": "d6c28d8578596288b8ca30f051048b6f5ce03934", "commit_rev":
"6044a51d3e0eff211412224d21f62777db7641a4"}
Message was sent while issue was closed.
Description was changed from ========== Flush TaskScheduler in ~ScopedTaskEnvironment and ~ScopedAsyncTaskScheduler. Skipping tasks when destroying ScopedTaskEnvironment or ScopedAsyncTaskScheduler means that DeleteSoon() tasks can be skipped, resulting in memory leaks. BUG=708584, 709095 ========== to ========== Flush TaskScheduler in ~ScopedTaskEnvironment and ~ScopedAsyncTaskScheduler. Skipping tasks when destroying ScopedTaskEnvironment or ScopedAsyncTaskScheduler means that DeleteSoon() tasks can be skipped, resulting in memory leaks. BUG=708584, 709095 Review-Url: https://codereview.chromium.org/2812293002 Cr-Commit-Position: refs/heads/master@{#464380} Committed: https://chromium.googlesource.com/chromium/src/+/6044a51d3e0eff211412224d21f6... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/6044a51d3e0eff211412224d21f6... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
