Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2812263004: Properly handle the case when a parallel download becomes non-parallel (Closed)

Created:
3 years, 8 months ago by qinmin
Modified:
3 years, 8 months ago
Reviewers:
xingliu
CC:
chromium-reviews, jam, David Trainor- moved to gerrit, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Properly handle the case when a parallel download becomes non-parallel When finch is used, it is possible that user can resume a previous parallel download without enabling parallel downloading. This change handles that case by truncating the file and discard all the received slices BUG=644352 Review-Url: https://codereview.chromium.org/2812263004 Cr-Commit-Position: refs/heads/master@{#464538} Committed: https://chromium.googlesource.com/chromium/src/+/4f3c18cf2a88b9a88f42fc18461522f718685e59

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
M content/browser/download/download_item_impl.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M content/browser/download/parallel_download_utils.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/download/parallel_download_utils.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download
M content/browser/download/parallel_download_utils_unittest.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
qinmin
PTAL
3 years, 8 months ago (2017-04-12 22:29:08 UTC) #2
xingliu
lgtm.
3 years, 8 months ago (2017-04-13 17:20:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812263004/1
3 years, 8 months ago (2017-04-13 17:26:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/429342)
3 years, 8 months ago (2017-04-13 17:33:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812263004/20001
3 years, 8 months ago (2017-04-13 19:56:28 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 20:51:26 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4f3c18cf2a88b9a88f42fc184615...

Powered by Google App Engine
This is Rietveld 408576698