Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2812253004: WebVR: handle window.rAF while presenting (Closed)

Created:
3 years, 8 months ago by klausw
Modified:
3 years, 7 months ago
Reviewers:
bajones
CC:
chromium-reviews, haraken, blink-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WebVR: handle window.rAF while presenting We currently aren't processing the normal vsync/BeginFrame events during WebVR presentation, this means that only vrDisplay.rAF callbacks get executed, not window.rAF callbacks. This breaks applications that depend on window.rAF for background processing, so we should continue executing those callbacks too. This patch does not enable requestIdleCallback handling, that is significantly more complex and we're looking into that separately. BUG=704341 Review-Url: https://codereview.chromium.org/2812253004 Cr-Commit-Position: refs/heads/master@{#464233} Committed: https://chromium.googlesource.com/chromium/src/+/5873ff63b705173921eddc8741704fbde962a41f

Patch Set 1 #

Patch Set 2 : WebVR: fix initial vsync and focus while presenting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -10 lines) Patch
M third_party/WebKit/Source/modules/vr/VRDisplay.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 1 14 chunks +110 lines, -9 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
klausw
3 years, 8 months ago (2017-04-12 22:40:01 UTC) #2
bajones
LGTM with one question: Will this fire even if no VRDisplay.rAF's have been scheduled? I ...
3 years, 8 months ago (2017-04-12 22:52:26 UTC) #3
klausw
On 2017/04/12 22:52:26, bajones wrote: > LGTM with one question: Will this fire even if ...
3 years, 8 months ago (2017-04-12 23:43:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812253004/1
3 years, 8 months ago (2017-04-12 23:43:44 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 01:40:02 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5873ff63b705173921eddc874170...

Powered by Google App Engine
This is Rietveld 408576698